Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_database.h

Issue 1970823002: Remove the unused OffDomainInclusionDetector (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix nits Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_database.h
diff --git a/chrome/browser/safe_browsing/safe_browsing_database.h b/chrome/browser/safe_browsing/safe_browsing_database.h
index a05e98cd81ec2593f78c6bba55e2e6c08b2332a9..9b1d7ff085e0dbee30ce45de1ad3baee1c8c6d93 100644
--- a/chrome/browser/safe_browsing/safe_browsing_database.h
+++ b/chrome/browser/safe_browsing/safe_browsing_database.h
@@ -158,9 +158,6 @@ class SafeBrowsingDatabase {
virtual bool ContainsDownloadWhitelistedUrl(const GURL& url) = 0;
virtual bool ContainsDownloadWhitelistedString(const std::string& str) = 0;
- // Returns true if |url| is on the off-domain inclusion whitelist.
- virtual bool ContainsInclusionWhitelistedUrl(const GURL& url) = 0;
-
// Returns true if the given module is on the module whitelist.
virtual bool ContainsModuleWhitelistedString(const std::string& str) = 0;
@@ -254,7 +251,8 @@ class SafeBrowsingDatabase {
static base::FilePath DownloadWhitelistDBFilename(
const base::FilePath& download_whitelist_base_filename);
- // Filename for the off-domain inclusion whitelist databsae.
+ // Filename for the off-domain inclusion whitelist databsae. This database no
+ // longer exists, but the filename is retained so the database may be deleted.
static base::FilePath InclusionWhitelistDBFilename(
const base::FilePath& inclusion_whitelist_base_filename);
@@ -355,7 +353,6 @@ class SafeBrowsingDatabaseNew : public SafeBrowsingDatabase {
SafeBrowsingStore* download_store,
SafeBrowsingStore* csd_whitelist_store,
SafeBrowsingStore* download_whitelist_store,
- SafeBrowsingStore* inclusion_whitelist_store,
SafeBrowsingStore* extension_blacklist_store,
SafeBrowsingStore* ip_blacklist_store,
SafeBrowsingStore* unwanted_software_store,
@@ -386,7 +383,6 @@ class SafeBrowsingDatabaseNew : public SafeBrowsingDatabase {
bool ContainsCsdWhitelistedUrl(const GURL& url) override;
bool ContainsDownloadWhitelistedUrl(const GURL& url) override;
bool ContainsDownloadWhitelistedString(const std::string& str) override;
- bool ContainsInclusionWhitelistedUrl(const GURL& url) override;
bool ContainsModuleWhitelistedString(const std::string& str) override;
bool ContainsExtensionPrefixes(const std::vector<SBPrefix>& prefixes,
std::vector<SBPrefix>* prefix_hits) override;
@@ -448,7 +444,6 @@ class SafeBrowsingDatabaseNew : public SafeBrowsingDatabase {
enum class SBWhitelistId {
CSD,
DOWNLOAD,
- INCLUSION,
MODULE,
};
enum class PrefixSetId {
@@ -709,8 +704,6 @@ class SafeBrowsingDatabaseNew : public SafeBrowsingDatabase {
// bit hashes.
// - |download_whitelist_store_|: For the download whitelist chunks and
// full-length hashes. This list only contains 256 bit hashes.
- // - |inclusion_whitelist_store_|: For the inclusion whitelist. Same format
- // as |download_whitelist_store_|.
// - |extension_blacklist_store_|: For extension IDs.
// - |ip_blacklist_store_|: For IP blacklist.
// - |unwanted_software_store_|: For unwanted software list (format
@@ -730,7 +723,6 @@ class SafeBrowsingDatabaseNew : public SafeBrowsingDatabase {
const std::unique_ptr<SafeBrowsingStore> download_store_;
const std::unique_ptr<SafeBrowsingStore> csd_whitelist_store_;
const std::unique_ptr<SafeBrowsingStore> download_whitelist_store_;
- const std::unique_ptr<SafeBrowsingStore> inclusion_whitelist_store_;
const std::unique_ptr<SafeBrowsingStore> extension_blacklist_store_;
const std::unique_ptr<SafeBrowsingStore> ip_blacklist_store_;
const std::unique_ptr<SafeBrowsingStore> unwanted_software_store_;
« no previous file with comments | « chrome/browser/safe_browsing/local_database_manager.cc ('k') | chrome/browser/safe_browsing/safe_browsing_database.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698