third_party/WebKit/Source/core/page/scrolling/ViewportScrollCallback.cpp - Issue 1970763002: Fixed up root scroller API to be more webby

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/scrolling/ViewportScrollCallback.cpp

Issue 1970763002: Fixed up root scroller API to be more webby (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Sigh...fix test expectation again, fix crash when there's no renderer Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/page/scrolling/ViewportScrollCallback.h ('k') | third_party/WebKit/Source/web/tests/RootScrollerTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/scrolling/ViewportScrollCallback.cpp

diff --git a/third_party/WebKit/Source/core/page/scrolling/ViewportScrollCallback.cpp b/third_party/WebKit/Source/core/page/scrolling/ViewportScrollCallback.cpp

index 663c55f5fc8ea71cbd6732342a3ab3728a2199e8..77572aed0c5571f8c19e15978303f666aed79649 100644

--- a/third_party/WebKit/Source/core/page/scrolling/ViewportScrollCallback.cpp

+++ b/third_party/WebKit/Source/core/page/scrolling/ViewportScrollCallback.cpp

@@ -96,9 +96,9 @@ void ViewportScrollCallback::handleEvent(ScrollState* state)

state->deltaY() - result.unusedScrollDeltaY);

}

-void ViewportScrollCallback::setScroller(ScrollableArea& scroller)

+void ViewportScrollCallback::setScroller(ScrollableArea* scroller)

{

- m_scroller = &scroller;

+ m_scroller = scroller;

}

} // namespace blink