Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(814)

Issue 1970743003: Test Physical Web metadata serialization (Closed)

Created:
4 years, 7 months ago by cco3
Modified:
4 years, 7 months ago
Reviewers:
nyquist, mattreynolds
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Test Physical Web metadata serialization The PhysicalWeb has a cache of metadata that gets stored to local disk. This isn't absolutely required for mostly-correct functionality, so it's easy to overlook whether it's worker properly. This change tests that the cache works as intended. BUG=598106, 596668 Committed: https://crrev.com/e3613ae3fbe705718127881c5dad8dc2d4fb536f Cr-Commit-Position: refs/heads/master@{#393400}

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 1

Patch Set 3 : Use URL2 instead of URL1 + 1 #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -16 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlInfo.java View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java_sources.gni View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/UrlInfoTest.java View 1 chunk +43 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/UrlManagerTest.java View 1 2 3 7 chunks +32 lines, -13 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
cco3
4 years, 7 months ago (2016-05-11 21:22:59 UTC) #2
mattreynolds
lgtm
4 years, 7 months ago (2016-05-11 21:26:07 UTC) #3
nyquist
lgtm https://codereview.chromium.org/1970743003/diff/20001/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/UrlManagerTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/UrlManagerTest.java (right): https://codereview.chromium.org/1970743003/diff/20001/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/UrlManagerTest.java#newcode230 chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/UrlManagerTest.java:230: String url2 = URL1 + 1; Nit: Could ...
4 years, 7 months ago (2016-05-12 20:06:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1970743003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1970743003/40001
4 years, 7 months ago (2016-05-12 20:39:25 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/212713)
4 years, 7 months ago (2016-05-12 21:31:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1970743003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1970743003/60001
4 years, 7 months ago (2016-05-12 21:39:39 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1970743003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1970743003/60001
4 years, 7 months ago (2016-05-12 21:46:21 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-12 23:54:27 UTC) #19
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 23:56:01 UTC) #21
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e3613ae3fbe705718127881c5dad8dc2d4fb536f
Cr-Commit-Position: refs/heads/master@{#393400}

Powered by Google App Engine
This is Rietveld 408576698