Make rietveld test work on port 10000.

Make rietveld test work on port 10000.

depot_tools PRESUBMIT.py and tools/build PRESUBMIT.py both run on cq.golo.

If broken dev_appserver.py instances are left around, they will conflict with
master ports.

BUG=351926
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=256721

[ghost stip (do not use), 2014-03-12 22:26:21]

ptal

[iannucci, 2014-03-12 22:42:25]

lgtm, assuming it works

[ghost stip (do not use), 2014-03-12 22:43:27]

The CQ bit was checked by stip@chromium.org

[commit-bot: I haz the power, 2014-03-12 22:43:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stip@chromium.org/197073007/1

[commit-bot: I haz the power, 2014-03-12 22:45:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-12 22:45:04]

Presubmit check for 197073007-1 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
push-basic.sh failed
Command /b/commit-queue/workdir/tools/depot_tools/tests/push-basic.sh returned
non-zero exit status 1 in /b/commit-queue/workdir/tools/depot_tools/tests
Setting up test upstream git repo...
Setting up test git repo...
TESTING: git-cl upload wants a server
TESTING: git-cl status has no issue
TESTING: upload succeeds (needs a server running on localhost)
Traceback (most recent call last):
  File "/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py", line
2535, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py", line
2521, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/b/commit-queue/workdir/tools/depot_tools/subcommand.py", line 245, in
execute
    return command(parser, args[1:])
  File "/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py", line
1716, in CMDupload
    ret = RietveldUpload(options, args, cl)
  File "/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py", line
1593, in RietveldUpload
    issue, patchset = upload.RealMain(upload_args)
  File "/b/commit-queue/workdir/tools/depot_tools/third_party/upload.py", line
2656, in RealMain
    response_body = rpc_server.Send("/upload", body, content_type=ctype)
  File "/b/commit-queue/workdir/tools/depot_tools/third_party/upload.py", line
463, in Send
    f = self.opener.open(req)
  File "/usr/lib/python2.7/urllib2.py", line 400, in open
    response = self._open(req, data)
  File "/usr/lib/python2.7/urllib2.py", line 418, in _open
    '_open', req)
  File "/usr/lib/python2.7/urllib2.py", line 378, in _call_chain
    result = func(*args)
  File "/usr/lib/python2.7/urllib2.py", line 1207, in http_open
    return self.do_open(httplib.HTTPConnection, req)
  File "/usr/lib/python2.7/urllib2.py", line 1177, in do_open
    raise URLError(err)
urllib2.URLError: <urlopen error [Errno 111] Connection refused>
FAILURE: upload succeeds (needs a server running on localhost)


submit-from-new-dir.sh failed
Command /b/commit-queue/workdir/tools/depot_tools/tests/submit-from-new-dir.sh
returned non-zero exit status 1 in
/b/commit-queue/workdir/tools/depot_tools/tests
Setting up test SVN repo...
Setting up test git-svn repo...
TESTING: upload succeeds
Traceback (most recent call last):
  File "/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py", line
2535, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py", line
2521, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/b/commit-queue/workdir/tools/depot_tools/subcommand.py", line 245, in
execute
    return command(parser, args[1:])
  File "/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py", line
1716, in CMDupload
    ret = RietveldUpload(options, args, cl)
  File "/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py", line
1593, in RietveldUpload
    issue, patchset = upload.RealMain(upload_args)
  File "/b/commit-queue/workdir/tools/depot_tools/third_party/upload.py", line
2656, in RealMain
    response_body = rpc_server.Send("/upload", body, content_type=ctype)
  File "/b/commit-queue/workdir/tools/depot_tools/third_party/upload.py", line
463, in Send
    f = self.opener.open(req)
  File "/usr/lib/python2.7/urllib2.py", line 400, in open
    response = self._open(req, data)
  File "/usr/lib/python2.7/urllib2.py", line 418, in _open
    '_open', req)
  File "/usr/lib/python2.7/urllib2.py", line 378, in _call_chain
    result = func(*args)
  File "/usr/lib/python2.7/urllib2.py", line 1207, in http_open
    return self.do_open(httplib.HTTPConnection, req)
  File "/usr/lib/python2.7/urllib2.py", line 1177, in do_open
    raise URLError(err)
urllib2.URLError: <urlopen error [Errno 111] Connection refused>
FAILURE: upload succeeds


abandon.sh failed
Command /b/commit-queue/workdir/tools/depot_tools/tests/abandon.sh returned
non-zero exit status 1 in /b/commit-queue/workdir/tools/depot_tools/tests
Setting up test SVN repo...
Setting up test git-svn repo...
TESTING: upload succeeds
Traceback (most recent call last):
  File "/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py", line
2535, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py", line
2521, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/b/commit-queue/workdir/tools/depot_tools/subcommand.py", line 245, in
execute
    return command(parser, args[1:])
  File "/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py", line
1716, in CMDupload
    ret = RietveldUpload(options, args, cl)
  File "/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py", line
1593, in RietveldUpload
    issue, patchset = upload.RealMain(upload_args)
  File "/b/commit-queue/workdir/tools/depot_tools/third_party/upload.py", line
2656, in RealMain
    response_body = rpc_server.Send("/upload", body, content_type=ctype)
  File "/b/commit-queue/workdir/tools/depot_tools/third_party/upload.py", line
463, in Send
    f = self.opener.open(req)
  File "/usr/lib/python2.7/urllib2.py", line 400, in open
    response = self._open(req, data)
  File "/usr/lib/python2.7/urllib2.py", line 418, in _open
    '_open', req)
  File "/usr/lib/python2.7/urllib2.py", line 378, in _call_chain
    result = func(*args)
  File "/usr/lib/python2.7/urllib2.py", line 1207, in http_open
    return self.do_open(httplib.HTTPConnection, req)
  File "/usr/lib/python2.7/urllib2.py", line 1177, in do_open
    raise URLError(err)
urllib2.URLError: <urlopen error [Errno 111] Connection refused>
FAILURE: upload succeeds


upload-local-tracking-branch.sh failed
Command
/b/commit-queue/workdir/tools/depot_tools/tests/upload-local-tracking-branch.sh
returned non-zero exit status 1 in
/b/commit-queue/workdir/tools/depot_tools/tests
Setting up test upstream git repo...
Setting up test git repo...
TESTING: upload succeeds (needs a server running on localhost)
Traceback (most recent call last):
  File "/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py", line
2535, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py", line
2521, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/b/commit-queue/workdir/tools/depot_tools/subcommand.py", line 245, in
execute
    return command(parser, args[1:])
  File "/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py", line
1716, in CMDupload
    ret = RietveldUpload(options, args, cl)
  File "/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py", line
1593, in RietveldUpload
    issue, patchset = upload.RealMain(upload_args)
  File "/b/commit-queue/workdir/tools/depot_tools/third_party/upload.py", line
2656, in RealMain
    response_body = rpc_server.Send("/upload", body, content_type=ctype)
  File "/b/commit-queue/workdir/tools/depot_tools/third_party/upload.py", line
463, in Send
    f = self.opener.open(req)
  File "/usr/lib/python2.7/urllib2.py", line 400, in open
    response = self._open(req, data)
  File "/usr/lib/python2.7/urllib2.py", line 418, in _open
    '_open', req)
  File "/usr/lib/python2.7/urllib2.py", line 378, in _call_chain
    result = func(*args)
  File "/usr/lib/python2.7/urllib2.py", line 1207, in http_open
    return self.do_open(httplib.HTTPConnection, req)
  File "/usr/lib/python2.7/urllib2.py", line 1177, in do_open
    raise URLError(err)
urllib2.URLError: <urlopen error [Errno 111] Connection refused>
FAILURE: upload succeeds (needs a server running on localhost)


upload-stale.sh failed
Command /b/commit-queue/workdir/tools/depot_tools/tests/upload-stale.sh returned
non-zero exit status 1 in /b/commit-queue/workdir/tools/depot_tools/tests
Setting up test upstream git repo...
Setting up test git repo...
TESTING: upload succeeds (needs a server running on localhost)
Traceback (most recent call last):
  File "/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py", line
2535, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py", line
2521, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/b/commit-queue/workdir/tools/depot_tools/subcommand.py", line 245, in
execute
    return command(parser, args[1:])
  File "/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py", line
1716, in CMDupload
    ret = RietveldUpload(options, args, cl)
  File "/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py", line
1593, in RietveldUpload
    issue, patchset = upload.RealMain(upload_args)
  File "/b/commit-queue/workdir/tools/depot_tools/third_party/upload.py", line
2656, in RealMain
    response_body = rpc_server.Send("/upload", body, content_type=ctype)
  File "/b/commit-queue/workdir/tools/depot_tools/third_party/upload.py", line
463, in Send
    f = self.opener.open(req)
  File "/usr/lib/python2.7/urllib2.py", line 400, in open
    response = self._open(req, data)
  File "/usr/lib/python2.7/urllib2.py", line 418, in _open
    '_open', req)
  File "/usr/lib/python2.7/urllib2.py", line 378, in _call_chain
    result = func(*args)
  File "/usr/lib/python2.7/urllib2.py", line 1207, in http_open
    return self.do_open(httplib.HTTPConnection, req)
  File "/usr/lib/python2.7/urllib2.py", line 1177, in do_open
    raise URLError(err)
urllib2.URLError: <urlopen error [Errno 111] Connection refused>
FAILURE: upload succeeds (needs a server running on localhost)


patch.sh fail…
(message too large)

[ghost stip (do not use), 2014-03-12 22:48:12]

>:[

well it worked on my desktop...

[Ken Russell (switch to Gerrit), 2014-03-12 22:59:14]

On 2014/03/12 22:48:12, stip wrote:
> >:[
> 
> well it worked on my desktop...

Is the failing code related to authentication rather than Rietveld uploading
specifically?

[M-A Ruel, 2014-03-12 23:21:22]

On 2014/03/12 22:59:14, Ken Russell wrote:
> On 2014/03/12 22:48:12, stip wrote:
> > >:[
> > 
> > well it worked on my desktop...
> 
> Is the failing code related to authentication rather than Rietveld uploading
> specifically?

Why not create a proper try server builder so the CQ stops running it locally
instead of spending time on this?

[ghost stip (do not use), 2014-03-12 23:23:35]

On 2014/03/12 23:21:22, M-A Ruel wrote:
> On 2014/03/12 22:59:14, Ken Russell wrote:
> > On 2014/03/12 22:48:12, stip wrote:
> > > >:[
> > > 
> > > well it worked on my desktop...
> > 
> > Is the failing code related to authentication rather than Rietveld uploading
> > specifically?
> 
> Why not create a proper try server builder so the CQ stops running it locally
> instead of spending time on this?

I believe agable@ is doing just that.

[Marc-Antoine Ruel (Google), 2014-03-12 23:30:28]

On 2014/03/12 23:23:35, stip wrote:
> On 2014/03/12 23:21:22, M-A Ruel wrote:
> > On 2014/03/12 22:59:14, Ken Russell wrote:
> > > On 2014/03/12 22:48:12, stip wrote:
> > > > >:[
> > > > 
> > > > well it worked on my desktop...
> > > 
> > > Is the failing code related to authentication rather than Rietveld
uploading
> > > specifically?
> > 
> > Why not create a proper try server builder so the CQ stops running it
locally
> > instead of spending time on this?
> 
> I believe agable@ is doing just that.

Hooray!

[ghost stip (do not use), 2014-03-12 23:41:22]

Actually it looks like running presubmit with `presubmit_support.py *` doesn't
trigger it.

Running with a blank patch on master with `git cl presubmit` fails :(

[ghost stip (do not use), 2014-03-13 00:02:25]

Now with fixed tests. PTAL.

[ghost stip (do not use), 2014-03-13 01:03:49]

The CQ bit was checked by stip@chromium.org

[commit-bot: I haz the power, 2014-03-13 01:03:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stip@chromium.org/197073007/20001

[commit-bot: I haz the power, 2014-03-13 01:06:07]

Change committed as 256721