Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 197073002: Fix test/mac/gyptest-strip.py with Xcode 5.0 or higher (Closed)

Created:
6 years, 9 months ago by sdefresne
Modified:
6 years, 9 months ago
Reviewers:
Mark Mentovai
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Fix test/mac/gyptest-strip.py with Xcode 5.0 or higher The version of clang that ships with Xcode 5.0 and higher add an extra symbol if the command-line use a relative path with more than one component to reference the source file (like ./file.c). This extra symbol is not present if using an absolute path to the file, and cause a difference of behaviour between xcodebuild and ninja. Account for the extra symbol in the un-stripped binaries when building with ninja and using Xcode 5.0 or higher. A possible alternative would be to always use absolute path with ninja, but it would make the build environment non-relocatable. BUG=gyp:381 R=mark@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1869

Patch Set 1 #

Total comments: 6

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M test/mac/gyptest-strip.py View 1 2 chunks +12 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sdefresne
PTAL
6 years, 9 months ago (2014-03-12 13:00:43 UTC) #1
Mark Mentovai
LGTM I found that it’s not really relative paths that are the problem, a path ...
6 years, 9 months ago (2014-03-12 13:29:19 UTC) #2
sdefresne
Thank you for the reviews. https://codereview.chromium.org/197073002/diff/1/test/mac/gyptest-strip.py File test/mac/gyptest-strip.py (right): https://codereview.chromium.org/197073002/diff/1/test/mac/gyptest-strip.py#newcode39 test/mac/gyptest-strip.py:39: # Starting with Xcode ...
6 years, 9 months ago (2014-03-12 13:42:18 UTC) #3
sdefresne
6 years, 9 months ago (2014-03-12 13:47:33 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r1869 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698