Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1026)

Unified Diff: content/child/web_url_loader_impl.cc

Issue 1970693002: Use mojo for Chrome Loading, Part 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/web_url_loader_impl.cc
diff --git a/content/child/web_url_loader_impl.cc b/content/child/web_url_loader_impl.cc
index cf47c4fedca531c858a37319a37e9ef28da01743..e2f1da08c0865d98e993a4e5ed11b4c8160de5e5 100644
--- a/content/child/web_url_loader_impl.cc
+++ b/content/child/web_url_loader_impl.cc
@@ -35,6 +35,7 @@
#include "content/common/resource_request_body.h"
#include "content/common/service_worker/service_worker_types.h"
#include "content/common/ssl_status_serialization.h"
+#include "content/common/url_loader.mojom.h"
#include "content/public/child/fixed_received_data.h"
#include "content/public/child/request_peer.h"
#include "content/public/common/browser_side_navigation_policy.h"
@@ -278,7 +279,8 @@ class WebURLLoaderImpl::Context : public base::RefCounted<Context> {
Context(WebURLLoaderImpl* loader,
ResourceDispatcher* resource_dispatcher,
- std::unique_ptr<blink::WebTaskRunner> task_runner);
+ std::unique_ptr<blink::WebTaskRunner> task_runner,
+ mojom::URLLoaderFactory* factory);
WebURLLoaderClient* client() const { return client_; }
void set_client(WebURLLoaderClient* client) { client_ = client; }
@@ -340,6 +342,8 @@ class WebURLLoaderImpl::Context : public base::RefCounted<Context> {
enum DeferState {NOT_DEFERRING, SHOULD_DEFER, DEFERRED_DATA};
DeferState defers_loading_;
int request_id_;
+
+ mojom::URLLoaderFactory* url_loader_factory_;
};
// A thin wrapper class for Context to ensure its lifetime while it is
@@ -374,14 +378,16 @@ class WebURLLoaderImpl::RequestPeerImpl : public RequestPeer {
WebURLLoaderImpl::Context::Context(
WebURLLoaderImpl* loader,
ResourceDispatcher* resource_dispatcher,
- std::unique_ptr<blink::WebTaskRunner> web_task_runner)
+ std::unique_ptr<blink::WebTaskRunner> web_task_runner,
+ mojom::URLLoaderFactory* url_loader_factory)
: loader_(loader),
client_(NULL),
resource_dispatcher_(resource_dispatcher),
web_task_runner_(std::move(web_task_runner)),
referrer_policy_(blink::WebReferrerPolicyDefault),
defers_loading_(NOT_DEFERRING),
- request_id_(-1) {}
+ request_id_(-1),
+ url_loader_factory_(url_loader_factory) {}
void WebURLLoaderImpl::Context::Cancel() {
TRACE_EVENT_WITH_FLOW0("loading", "WebURLLoaderImpl::Context::Cancel", this,
@@ -534,10 +540,15 @@ void WebURLLoaderImpl::Context::Start(const WebURLRequest& request,
request_info.resource_body_stream_url = stream_override_->stream_url;
}
+ mojom::URLLoaderPtr loader = nullptr;
+ if (request.loadingIPC() == blink::WebURLRequest::LoadingIPC::Mojo) {
+ url_loader_factory_->CreateURLLoader(GetProxy(&loader));
+ }
kinuko 2016/05/20 09:38:51 nit: no {} for one-line body for consistency in th
yhirano 2016/05/20 11:32:54 Done.
+
if (sync_load_response) {
DCHECK(defers_loading_ == NOT_DEFERRING);
- resource_dispatcher_->StartSync(
- request_info, request_body.get(), sync_load_response);
+ resource_dispatcher_->StartSync(request_info, request_body.get(),
+ sync_load_response, std::move(loader));
return;
}
@@ -545,7 +556,8 @@ void WebURLLoaderImpl::Context::Start(const WebURLRequest& request,
TRACE_EVENT_FLAG_FLOW_OUT);
request_id_ = resource_dispatcher_->StartAsync(
request_info, request_body.get(),
- base::WrapUnique(new WebURLLoaderImpl::RequestPeerImpl(this)));
+ base::WrapUnique(new WebURLLoaderImpl::RequestPeerImpl(this)),
+ std::move(loader));
if (defers_loading_ != NOT_DEFERRING)
resource_dispatcher_->SetDefersLoading(request_id_, true);
@@ -915,9 +927,12 @@ void WebURLLoaderImpl::RequestPeerImpl::OnCompletedRequest(
WebURLLoaderImpl::WebURLLoaderImpl(
ResourceDispatcher* resource_dispatcher,
- std::unique_ptr<blink::WebTaskRunner> web_task_runner)
- : context_(
- new Context(this, resource_dispatcher, std::move(web_task_runner))) {}
+ std::unique_ptr<blink::WebTaskRunner> web_task_runner,
+ mojom::URLLoaderFactory* url_loader_factory)
+ : context_(new Context(this,
+ resource_dispatcher,
+ std::move(web_task_runner),
+ url_loader_factory)) {}
WebURLLoaderImpl::~WebURLLoaderImpl() {
cancel();

Powered by Google App Engine
This is Rietveld 408576698