content/public/common/BUILD.gn - Issue 1970693002: Use mojo for Chrome Loading, Part 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/common/BUILD.gn

Issue 1970693002: Use mojo for Chrome Loading, Part 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/public/common/BUILD.gn

diff --git a/content/public/common/BUILD.gn b/content/public/common/BUILD.gn

index 2df12fd39bbb5bfbf5d3dd81c79526ca8985a600..71186eef0f15cdd164b1e660eaff5ef0b836494d 100644

--- a/content/public/common/BUILD.gn

+++ b/content/public/common/BUILD.gn

@@ -110,6 +110,9 @@ source_set("common_sources") {

"//url/ipc:url_ipc",

]

deps = [

+ # This looks needless as we have //content/common in public_deps, but it's

+ # needed because of allow_circular_includes_from.

+ "//content/common:mojo_bindings_cpp_sources",

"//ipc",

"//media",

"//mojo/common",

@@ -130,7 +133,10 @@ source_set("common_sources") {

]

# //content/common needs to include public headers.

- allow_circular_includes_from = [ "//content/common" ]

+ allow_circular_includes_from = [

+ "//content/common",

+ "//content/common:mojo_bindings_cpp_sources",

+ ]

if (!enable_plugins) {

sources -= [

« no previous file with comments | « content/content_tests.gypi ('k') | content/renderer/renderer_blink_platform_impl.h » ('j') | no next file with comments »