Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1269)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/public/common/BUILD.gn

Issue 1970693002: Use mojo for Chrome Loading, Part 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/browser/loader/mojo_async_resource_handler_unittest.cc ('K') | « content/content_tests.gypi ('k') | content/renderer/renderer_blink_platform_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/common/BUILD.gn
diff --git a/content/public/common/BUILD.gn b/content/public/common/BUILD.gn
index 9432838d266fc701951510df089ff87648cdd8d5..a38a3967b082ab36eb8b81c1545566c2001b52b5 100644
--- a/content/public/common/BUILD.gn
+++ b/content/public/common/BUILD.gn
@@ -101,6 +101,9 @@ source_set("common_sources") {
"//url/ipc:url_ipc",
]
deps = [
+ # This looks needless as we have //content/common in public_deps, but it's
+ # needed because of allow_circular_includes_from.
+ "//content/common:mojo_bindings_cpp_sources",
"//ipc",
"//media",
"//mojo/common",
@@ -120,7 +123,10 @@ source_set("common_sources") {
]
# //content/common needs to include public headers.
- allow_circular_includes_from = [ "//content/common" ]
+ allow_circular_includes_from = [
+ "//content/common",
+ "//content/common:mojo_bindings_cpp_sources",
+ ]
if (!enable_plugins) {
sources -= [
« content/browser/loader/mojo_async_resource_handler_unittest.cc ('K') | « content/content_tests.gypi ('k') | content/renderer/renderer_blink_platform_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698