third_party/WebKit/LayoutTests/VirtualTestSuites - Issue 1970693002: Use mojo for Chrome Loading, Part 1

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/VirtualTestSuites

Issue 1970693002: Use mojo for Chrome Loading, Part 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/child/web_url_loader_impl.cc ('K') | « mojo/public/tools/bindings/chromium_bindings_configuration.gni ('k') | third_party/WebKit/LayoutTests/virtual/mojo-loading/webexposed/README.txt » ('j') | third_party/WebKit/public/platform/WebURLRequest.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 [	1 [

2 {	2 {

3 "prefix": "gpu",	3 "prefix": "gpu",

4 "base": "fast/canvas",	4 "base": "fast/canvas",

5 "args": ["--enable-accelerated-2d-canvas",	5 "args": ["--enable-accelerated-2d-canvas",

6 "--disable-display-list-2d-canvas"]	6 "--disable-display-list-2d-canvas"]

7 },	7 },

8 {	8 {

9 "prefix": "display_list_2d_canvas",	9 "prefix": "display_list_2d_canvas",

10 "base": "fast/canvas",	10 "base": "fast/canvas",

(...skipping 234 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
245 },	245 },

246 {	246 {

247 "prefix": "scalefactor200withzoom",	247 "prefix": "scalefactor200withzoom",

248 "base": "fast/hidpi/static",	248 "base": "fast/hidpi/static",

249 "args": ["--force-device-scale-factor=2", "--enable-use-zoom-for-dsf"]	249 "args": ["--force-device-scale-factor=2", "--enable-use-zoom-for-dsf"]

250 },	250 },

251 {	251 {

252 "prefix": "documentwriteevaluator",	252 "prefix": "documentwriteevaluator",

253 "base": "http/tests/preload/document-write",	253 "base": "http/tests/preload/document-write",

254 "args": ["--enable-blink-features=DocumentWriteEvaluator"]	254 "args": ["--enable-blink-features=DocumentWriteEvaluator"]

	255 },

	256 {

	257 "prefix": "mojo-loading",

	258 "base": "webexposed",
	kinuko 2016/05/20 09:38:51 Why webexposed? Does the directory have interestin Why webexposed? Does the directory have interesting basic loading tests?? yhirano 2016/05/20 11:32:54 It's important that they are not interesting. Mojo Show quoted text On 2016/05/20 09:38:51, kinuko wrote: > Why webexposed? Does the directory have interesting basic loading tests?? It's important that they are not interesting. Mojo is used when html files are fetched, and that's what I want to test for this change. kinuko 2016/05/20 15:56:46 Oh I see... (I wish we could have a comment to not Show quoted text On 2016/05/20 11:32:54, yhirano wrote: > On 2016/05/20 09:38:51, kinuko wrote: > > Why webexposed? Does the directory have interesting basic loading tests?? > > It's important that they are not interesting. Mojo is used when html files are > fetched, and that's what I want to test for this change. Oh I see... (I wish we could have a comment to note that in this file... but it's json and maybe we can't) yhirano 2016/05/23 11:29:37 Added a comment in README.txt. Show quoted text On 2016/05/20 15:56:46, kinuko wrote: > On 2016/05/20 11:32:54, yhirano wrote: > > On 2016/05/20 09:38:51, kinuko wrote: > > > Why webexposed? Does the directory have interesting basic loading tests?? > > > > It's important that they are not interesting. Mojo is used when html files are > > fetched, and that's what I want to test for this change. > > Oh I see... (I wish we could have a comment to note that in this file... but > it's json and maybe we can't) Added a comment in README.txt.
	259 "args": ["--enable-blink-features=LoadingWithMojo"]

255 }	260 }

256 ]	261 ]

OLD	NEW