Use mojo for Chrome Loading, Part 1

content/browser/loader/resource_message_filter.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/loader/resource_message_filter.h"
 
 #include "content/browser/appcache/chrome_appcache_service.h"
 #include "content/browser/blob_storage/chrome_blob_storage_context.h"
 #include "content/browser/loader/resource_dispatcher_host_impl.h"
 #include "content/browser/service_worker/service_worker_context_wrapper.h"
@@ skipping 28 matching lines @@
 void ResourceMessageFilter::OnChannelClosing() {
   // Unhook us from all pending network requests so they don't get sent to a
   // deleted object.
   ResourceDispatcherHostImpl::Get()->CancelRequestsForProcess(child_id_);
 }
 
 bool ResourceMessageFilter::OnMessageReceived(const IPC::Message& message) {
   return ResourceDispatcherHostImpl::Get()->OnMessageReceived(message, this);
 }
 
+void ResourceMessageFilter::OnDestruct() const {
+  // Destroy the filter on the IO thread since that's where its weak pointers
+  // are being used.
+  BrowserThread::DeleteOnIOThread::Destruct(this);
+}
+
 void ResourceMessageFilter::GetContexts(
     ResourceType resource_type,
     int origin_pid,
     ResourceContext** resource_context,
     net::URLRequestContext** request_context) {
   return get_contexts_callback_.Run(resource_type, origin_pid, resource_context,
                                     request_context);
 }
 
+bool ResourceMessageFilter::Send(IPC::Message* message) {
+  if (message->is_sync()) {
+    // We don't support sending synchronous messages from the browser.
+    NOTREACHED() << "Can't send sync message through ResourceMessageFilter!";

[kinuko, 2016/05/20 09:38:51]

nit: any reason we don't use CHECK or DCHECK here, we're in the browser process
so this shouldn't happen other than by coding so?

[yhirano, 2016/05/20 11:32:54]

NOTREACHED is DCHECK.

https://code.google.com/p/chromium/codesearch#chromium/src/base/logging.h&q=n...

[kinuko, 2016/05/20 15:56:46]

I'm meaning this:

https://www.chromium.org/developers/coding-style#TOC-CHECK-DCHECK-and-NOTREAC...

Handling DCHECK failure is discouraged, just use DCHECK instead if it wouldn't
happen other than by coding error.

+    return false;
+  }
+
+  if (!BrowserThread::CurrentlyOn(BrowserThread::IO)) {
+    BrowserThread::PostTask(
+        BrowserThread::IO, FROM_HERE,
+        base::Bind(base::IgnoreResult(&ResourceMessageFilter::Send), this,
+                   message));
+    return true;
+  }
+
+  if (ResourceDispatcherHostImpl::Get()->SendWithMojoIfPossible(*message,
+                                                                this)) {
+    delete message;
+    return true;
+  }
+
+  return BrowserMessageFilter::Send(message);
+}
+
 base::WeakPtr<ResourceMessageFilter> ResourceMessageFilter::GetWeakPtr() {
+  DCHECK_CURRENTLY_ON(BrowserThread::IO);
   return weak_ptr_factory_.GetWeakPtr();
 }
 
 }  // namespace content