Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Unified Diff: third_party/WebKit/Source/web/ExternalPopupMenu.h

Issue 1970653003: ExternalPopupMenu should recreate its popup only if a SELECT subtree is updated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add an enum argument to updateFromElement Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/PopupMenu.h ('k') | third_party/WebKit/Source/web/ExternalPopupMenu.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/ExternalPopupMenu.h
diff --git a/third_party/WebKit/Source/web/ExternalPopupMenu.h b/third_party/WebKit/Source/web/ExternalPopupMenu.h
index a637cf7bcb3ef7abf7b81cce07e01c724a43cda8..e11ef4b9308408c2ccbf2afd523505d3739eb0ec 100644
--- a/third_party/WebKit/Source/web/ExternalPopupMenu.h
+++ b/third_party/WebKit/Source/web/ExternalPopupMenu.h
@@ -69,7 +69,7 @@ private:
// PopupMenu methods:
void show() override;
void hide() override;
- void updateFromElement() override;
+ void updateFromElement(UpdateReason) override;
void disconnectClient() override;
// WebExternalPopupClient methods:
@@ -89,7 +89,6 @@ private:
Timer<ExternalPopupMenu> m_dispatchEventTimer;
// The actual implementor of the show menu.
WebExternalPopupMenu* m_webExternalPopupMenu;
- uint64_t m_shownDOMTreeVersion = 0;
bool m_needsUpdate = false;
};
« no previous file with comments | « third_party/WebKit/Source/platform/PopupMenu.h ('k') | third_party/WebKit/Source/web/ExternalPopupMenu.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698