Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Unified Diff: third_party/WebKit/Source/core/html/HTMLSelectElement.h

Issue 1970653003: ExternalPopupMenu should recreate its popup only if a SELECT subtree is updated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add an enum argument to updateFromElement Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLSelectElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/HTMLSelectElement.h
diff --git a/third_party/WebKit/Source/core/html/HTMLSelectElement.h b/third_party/WebKit/Source/core/html/HTMLSelectElement.h
index 450d0846a2da92330da73f8fcbd73ceaf825e0ab..450b34ffd00eb09faeed9ef5127538b38b7d676f 100644
--- a/third_party/WebKit/Source/core/html/HTMLSelectElement.h
+++ b/third_party/WebKit/Source/core/html/HTMLSelectElement.h
@@ -152,6 +152,7 @@ public:
void showPopup();
void hidePopup();
PopupMenu* popup() const { return m_popup.get(); }
+ void didMutateSubtree();
void resetTypeAheadSessionForTesting();
@@ -249,6 +250,9 @@ private:
int optionCount() const override;
String optionAtIndex(int index) const override;
+ void observeTreeMutation();
+ void unobserveTreeMutation();
+
// m_listItems contains HTMLOptionElement, HTMLOptGroupElement, and
// HTMLHRElement objects.
mutable ListItems m_listItems;
@@ -266,6 +270,8 @@ private:
int m_suggestedIndex;
bool m_isAutofilledByPreview;
+ class PopupUpdater;
+ Member<PopupUpdater> m_popupUpdater;
Member<PopupMenu> m_popup;
int m_indexToSelectOnCancel;
bool m_popupIsVisible;
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLSelectElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698