third_party/WebKit/Source/web/ExternalPopupMenu.h - Issue 1970653003: ExternalPopupMenu should recreate its popup only if a SELECT subtree is updated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ExternalPopupMenu.h

Issue 1970653003: ExternalPopupMenu should recreate its popup only if a SELECT subtree is updated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove ExternalPopupMenu::m_shownDOMTreeVersion Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/html/HTMLSelectElement.cpp ('K') | « third_party/WebKit/Source/platform/PopupMenu.h ('k') | third_party/WebKit/Source/web/ExternalPopupMenu.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/ExternalPopupMenu.h

diff --git a/third_party/WebKit/Source/web/ExternalPopupMenu.h b/third_party/WebKit/Source/web/ExternalPopupMenu.h

index a637cf7bcb3ef7abf7b81cce07e01c724a43cda8..013947bab138618a9d86046ac255d97f495d3ee1 100644

--- a/third_party/WebKit/Source/web/ExternalPopupMenu.h

+++ b/third_party/WebKit/Source/web/ExternalPopupMenu.h

@@ -70,6 +70,7 @@ private:

void show() override;

void hide() override;

void updateFromElement() override;

+ void updateFromElementWithMutation() override;

void disconnectClient() override;

// WebExternalPopupClient methods:

@@ -89,7 +90,6 @@ private:

Timer<ExternalPopupMenu> m_dispatchEventTimer;

// The actual implementor of the show menu.

WebExternalPopupMenu* m_webExternalPopupMenu;

- uint64_t m_shownDOMTreeVersion = 0;

bool m_needsUpdate = false;

};