Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: third_party/WebKit/Source/platform/PopupMenu.h

Issue 1970653003: ExternalPopupMenu should recreate its popup only if a SELECT subtree is updated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add an enum argument to updateFromElement Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 14 matching lines...) Expand all
25 #include "platform/heap/Handle.h" 25 #include "platform/heap/Handle.h"
26 26
27 namespace blink { 27 namespace blink {
28 28
29 class PopupMenu : public GarbageCollectedFinalized<PopupMenu> { 29 class PopupMenu : public GarbageCollectedFinalized<PopupMenu> {
30 public: 30 public:
31 virtual ~PopupMenu() { } 31 virtual ~PopupMenu() { }
32 DEFINE_INLINE_VIRTUAL_TRACE() { } 32 DEFINE_INLINE_VIRTUAL_TRACE() { }
33 virtual void show() = 0; 33 virtual void show() = 0;
34 virtual void hide() = 0; 34 virtual void hide() = 0;
35 virtual void updateFromElement() = 0; 35 enum UpdateReason {
36 BySelectionChange,
37 ByStyleChange,
38 ByDOMChange,
39 };
40 virtual void updateFromElement(UpdateReason) = 0;
36 virtual void disconnectClient() = 0; 41 virtual void disconnectClient() = 0;
37 }; 42 };
38 43
39 } // namespace blink 44 } // namespace blink
40 45
41 #endif // PopupMenu_h 46 #endif // PopupMenu_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/loader/EmptyClients.cpp ('k') | third_party/WebKit/Source/web/ExternalPopupMenu.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698