Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: third_party/WebKit/Source/core/loader/EmptyClients.cpp

Issue 1970653003: ExternalPopupMenu should recreate its popup only if a SELECT subtree is updated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add an enum argument to updateFromElement Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006 Eric Seidel <eric@webkit.org> 2 * Copyright (C) 2006 Eric Seidel <eric@webkit.org>
3 * Copyright (C) 2008, 2009, 2012 Apple Inc. All rights reserved. 3 * Copyright (C) 2008, 2009, 2012 Apple Inc. All rights reserved.
4 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 4 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 pageClients.editorClient = &dummyEditorClient; 55 pageClients.editorClient = &dummyEditorClient;
56 56
57 DEFINE_STATIC_LOCAL(EmptySpellCheckerClient, dummySpellCheckerClient, ()); 57 DEFINE_STATIC_LOCAL(EmptySpellCheckerClient, dummySpellCheckerClient, ());
58 pageClients.spellCheckerClient = &dummySpellCheckerClient; 58 pageClients.spellCheckerClient = &dummySpellCheckerClient;
59 } 59 }
60 60
61 class EmptyPopupMenu : public PopupMenu { 61 class EmptyPopupMenu : public PopupMenu {
62 public: 62 public:
63 void show() override { } 63 void show() override { }
64 void hide() override { } 64 void hide() override { }
65 void updateFromElement() override { } 65 void updateFromElement(UpdateReason) override { }
66 void disconnectClient() override { } 66 void disconnectClient() override { }
67 }; 67 };
68 68
69 class EmptyFrameScheduler : public WebFrameScheduler { 69 class EmptyFrameScheduler : public WebFrameScheduler {
70 public: 70 public:
71 void setFrameVisible(bool) override { } 71 void setFrameVisible(bool) override { }
72 WebTaskRunner* loadingTaskRunner() override; 72 WebTaskRunner* loadingTaskRunner() override;
73 WebTaskRunner* timerTaskRunner() override; 73 WebTaskRunner* timerTaskRunner() override;
74 }; 74 };
75 75
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
171 { 171 {
172 return nullptr; 172 return nullptr;
173 } 173 }
174 174
175 PassOwnPtr<WebApplicationCacheHost> EmptyFrameLoaderClient::createApplicationCac heHost(WebApplicationCacheHostClient*) 175 PassOwnPtr<WebApplicationCacheHost> EmptyFrameLoaderClient::createApplicationCac heHost(WebApplicationCacheHostClient*)
176 { 176 {
177 return nullptr; 177 return nullptr;
178 } 178 }
179 179
180 } // namespace blink 180 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLSelectElement.cpp ('k') | third_party/WebKit/Source/platform/PopupMenu.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698