third_party/WebKit/Source/platform/PopupMenu.h - Issue 1970653003: ExternalPopupMenu should recreate its popup only if a SELECT subtree is updated

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/platform/PopupMenu.h

Issue 1970653003: ExternalPopupMenu should recreate its popup only if a SELECT subtree is updated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove ExternalPopupMenu::m_shownDOMTreeVersion Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/core/html/HTMLSelectElement.cpp ('K') | « third_party/WebKit/Source/core/loader/EmptyClients.cpp ('k') | third_party/WebKit/Source/web/ExternalPopupMenu.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).	2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).

3 *	3 *

4 * This library is free software; you can redistribute it and/or	4 * This library is free software; you can redistribute it and/or

5 * modify it under the terms of the GNU Library General Public	5 * modify it under the terms of the GNU Library General Public

6 * License as published by the Free Software Foundation; either	6 * License as published by the Free Software Foundation; either

7 * version 2 of the License, or (at your option) any later version.	7 * version 2 of the License, or (at your option) any later version.

8 *	8 *

9 * This library is distributed in the hope that it will be useful,	9 * This library is distributed in the hope that it will be useful,

10 * but WITHOUT ANY WARRANTY; without even the implied warranty of	10 * but WITHOUT ANY WARRANTY; without even the implied warranty of

(...skipping 15 matching lines...) Expand all Loading...
26	26

27 namespace blink {	27 namespace blink {

28	28

29 class PopupMenu : public GarbageCollectedFinalized<PopupMenu> {	29 class PopupMenu : public GarbageCollectedFinalized<PopupMenu> {

30 public:	30 public:

31 virtual ~PopupMenu() { }	31 virtual ~PopupMenu() { }

32 DEFINE_INLINE_VIRTUAL_TRACE() { }	32 DEFINE_INLINE_VIRTUAL_TRACE() { }

33 virtual void show() = 0;	33 virtual void show() = 0;

34 virtual void hide() = 0;	34 virtual void hide() = 0;

35 virtual void updateFromElement() = 0;	35 virtual void updateFromElement() = 0;

	36 virtual void updateFromElementWithMutation() = 0;

36 virtual void disconnectClient() = 0;	37 virtual void disconnectClient() = 0;

37 };	38 };

38	39

39 } // namespace blink	40 } // namespace blink

40	41

41 #endif // PopupMenu_h	42 #endif // PopupMenu_h

OLD	NEW