Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1970643002: ParamTraits version of https://codereview.chromium.org/1896883002/ (Closed)

Created:
4 years, 7 months ago by jam
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tdresser+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, scheib+watch_chromium.org, darin-cc_chromium.org, cmumford, piman+watch_chromium.org, ortuno+watch_chromium.org, cc-bugs_chromium.org, jsbell+idb_chromium.org, ben+mojo_chromium.org, darin (slow to review)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ParamTraits version of https://codereview.chromium.org/1896883002/ Mojo interfaces needed for switching audio rendering stream creation and closing from IPC to Mojo This adds: * AudioOutput which allows managing audio output streams. * AudioOutputStream which handles audio output stream operations. This is the media part: The content part is in the CL http://codereview.chromium.org/1930393002 BUG=606707 patch from issue 1896883002 at patchset 520001 (http://crrev.com/1896883002#ps520001)

Patch Set 1 #

Patch Set 2 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+566 lines, -9 lines) Patch
M base/pickle.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M base/pickle.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M content/common/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/common/cc_messages.h View 6 chunks +6 lines, -0 lines 0 comments Download
M content/common/cc_messages.cc View 6 chunks +78 lines, -0 lines 0 comments Download
M content/common/content_message_generator.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M content/common/content_param_traits.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/content_param_traits.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M content/common/indexed_db/indexed_db_param_traits.h View 3 chunks +3 lines, -0 lines 0 comments Download
M content/common/indexed_db/indexed_db_param_traits.cc View 3 chunks +55 lines, -0 lines 0 comments Download
M content/common/input/input_param_traits.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/input/input_param_traits.cc View 1 chunk +8 lines, -0 lines 0 comments Download
A content/common/media/audio_output.mojom View 1 1 chunk +35 lines, -0 lines 0 comments Download
A + content/common/media/audio_parameters.mojom View 1 1 chunk +9 lines, -8 lines 0 comments Download
A content/common/media/audio_parameters.typemap View 1 1 chunk +11 lines, -0 lines 0 comments Download
M content/common/media/media_param_traits.h View 2 chunks +2 lines, -0 lines 0 comments Download
M content/common/media/media_param_traits.cc View 2 chunks +20 lines, -0 lines 0 comments Download
A + content/common/media/typemaps.gni View 1 chunk +1 line, -1 line 0 comments Download
M content/common/resource_messages.h View 5 chunks +5 lines, -0 lines 0 comments Download
M content/common/resource_messages.cc View 5 chunks +99 lines, -0 lines 0 comments Download
M content/content_common_mojo_bindings.gyp View 1 2 chunks +3 lines, -0 lines 0 comments Download
M content/public/common/common_param_traits.h View 5 chunks +5 lines, -0 lines 0 comments Download
M content/public/common/common_param_traits.cc View 6 chunks +37 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_uuid.h View 2 chunks +2 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_uuid.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ipc/ipc_message.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M ipc/ipc_message_utils.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M ipc/ipc_message_utils.cc View 1 3 chunks +22 lines, -0 lines 0 comments Download
M ipc/mach_port_mac.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M ipc/mach_port_mac.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M media/gpu/ipc/common/media_param_traits.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/chromium_bindings_configuration.gni View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/tools/bindings/mojom.gni View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/ipc/latency_info_param_traits.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/ipc/latency_info_param_traits.cc View 2 chunks +20 lines, -0 lines 0 comments Download
M ui/gfx/ipc/geometry/gfx_param_traits.h View 7 chunks +7 lines, -0 lines 0 comments Download
M ui/gfx/ipc/geometry/gfx_param_traits.cc View 7 chunks +39 lines, -0 lines 0 comments Download
M ui/gfx/ipc/gfx_param_traits.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M ui/gfx/ipc/gfx_param_traits.cc View 1 3 chunks +19 lines, -0 lines 0 comments Download
M ui/gfx/ipc/skia/gfx_skia_param_traits.h View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/gfx/ipc/skia/gfx_skia_param_traits.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M url/ipc/url_param_traits.h View 1 chunk +1 line, -0 lines 0 comments Download
M url/ipc/url_param_traits.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (4 generated)
jam
Patchset #3 (id:40001) has been deleted
4 years, 7 months ago (2016-05-11 04:26:16 UTC) #1
jam
Patchset #2 (id:20001) has been deleted
4 years, 7 months ago (2016-05-11 04:26:25 UTC) #2
jam
Patchset #2 (id:60001) has been deleted
4 years, 7 months ago (2016-05-11 05:26:32 UTC) #3
rchtara
4 years, 7 months ago (2016-05-12 10:47:52 UTC) #4 
Description was changed from

==========
ParamTraits version of https://codereview.chromium.org/1896883002/


Mojo interfaces needed for switching audio rendering stream creation and closing
from IPC to Mojo

This adds:
 * AudioOutput which allows managing audio output streams.
 * AudioOutputStream which handles audio output stream operations.
 * AudioOutputStreamParameters Mojo structure used by AudioOuput.
 * AudioOutputStreamParameters/AudioParameters converters needed later.

This is the media part: The content part is in the CL
http://codereview.chromium.org/1930393002

BUG=606707

patch from issue 1896883002 at patchset 520001
(http://crrev.com/1896883002#ps520001)
==========

to

==========
ParamTraits version of https://codereview.chromium.org/1896883002/


Mojo interfaces needed for switching audio rendering stream creation and closing
from IPC to Mojo

This adds:
 * AudioOutput which allows managing audio output streams.
 * AudioOutputStream which handles audio output stream operations.


This is the media part: The content part is in the CL
http://codereview.chromium.org/1930393002

BUG=606707

patch from issue 1896883002 at patchset 520001
(http://crrev.com/1896883002#ps520001)
==========

Powered by Google App Engine
This is Rietveld 408576698