Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1970623002: Set toolchain directory in gyp_chromium. (Closed)

Created:
4 years, 7 months ago by justincohen
Modified:
4 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set toolchain directory in gyp_chromium. Since the bots run gyp_chromium seperately from runhooks, the hermetic mac toolchain environment variables need to be set in this script as well. BUG=474373 Committed: https://crrev.com/588af0bb9a83d6441c00858ca5ae74a919706e74 Cr-Commit-Position: refs/heads/master@{#392822}

Patch Set 1 #

Patch Set 2 : empty line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/gyp_chromium.py View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
justincohen
The bots have their own standalone gyp gen step, so right now the hermetic toolchain ...
4 years, 7 months ago (2016-05-11 00:52:38 UTC) #2
Nico
lgtm
4 years, 7 months ago (2016-05-11 01:09:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1970623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1970623002/20001
4 years, 7 months ago (2016-05-11 01:10:33 UTC) #5
Nico
but please add the tracking BUG=
4 years, 7 months ago (2016-05-11 01:10:33 UTC) #6
justincohen
Done!
4 years, 7 months ago (2016-05-11 01:16:02 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-11 02:09:59 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 02:12:35 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/588af0bb9a83d6441c00858ca5ae74a919706e74
Cr-Commit-Position: refs/heads/master@{#392822}

Powered by Google App Engine
This is Rietveld 408576698