Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1970573003: Dart: Faster 'gen' command for mojom.dart tool (Closed)

Created:
4 years, 7 months ago by zra
Modified:
4 years, 7 months ago
Reviewers:
Cutch
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Dart: Faster 'gen' command for mojom.dart tool On my machine: $ ./mojo/dart/tools/bindings/generate.py -f Goes from ~45-50s to ~5-6s. R=johnmccutchan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/aac1322758450a256de74cf16f6e7deaed711d61

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -2 lines) Patch
M mojo/dart/packages/mojom/lib/src/generate.dart View 2 chunks +55 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
zra
4 years, 7 months ago (2016-05-11 21:02:28 UTC) #3
Cutch
lgtm
4 years, 7 months ago (2016-05-11 21:10:50 UTC) #4
zra
4 years, 7 months ago (2016-05-11 21:28:24 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
aac1322758450a256de74cf16f6e7deaed711d61 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698