Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1970543003: [formatting] Remove all double blank lines in WASM code. (Closed)

Created:
4 years, 7 months ago by titzer
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[formatting] Remove all double blank lines in WASM code. R=ahaas@chromium.org,mstarzinger@chromium.org BUG= Committed: https://crrev.com/bf90d9a33a694f37f8ddeb63c6ece0d1c6bc979a Cr-Commit-Position: refs/heads/master@{#36174}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -302 lines) Patch
M src/compiler/wasm-compiler.cc View 24 chunks +0 lines, -38 lines 0 comments Download
M src/wasm/ast-decoder.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/wasm/encoder.cc View 19 chunks +0 lines, -30 lines 0 comments Download
M src/wasm/module-decoder.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M src/wasm/wasm-js.cc View 9 chunks +0 lines, -10 lines 0 comments Download
M src/wasm/wasm-module.cc View 6 chunks +0 lines, -6 lines 0 comments Download
M src/wasm/wasm-opcodes.cc View 4 chunks +0 lines, -6 lines 0 comments Download
M src/wasm/wasm-result.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/wasm/test-run-wasm.cc View 114 chunks +0 lines, -124 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-js.cc View 15 chunks +0 lines, -20 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-module.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M test/unittests/wasm/ast-decoder-unittest.cc View 10 chunks +0 lines, -12 lines 0 comments Download
M test/unittests/wasm/encoder-unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M test/unittests/wasm/loop-assignment-analysis-unittest.cc View 10 chunks +0 lines, -12 lines 0 comments Download
M test/unittests/wasm/module-decoder-unittest.cc View 24 chunks +0 lines, -25 lines 0 comments Download
M test/unittests/wasm/wasm-macro-gen-unittest.cc View 9 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
titzer
4 years, 7 months ago (2016-05-11 11:56:34 UTC) #1
Michael Starzinger
LGTM (rubber-stamped).
4 years, 7 months ago (2016-05-11 11:57:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1970543003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1970543003/1
4 years, 7 months ago (2016-05-11 11:58:23 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-11 12:34:04 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 12:36:11 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/bf90d9a33a694f37f8ddeb63c6ece0d1c6bc979a
Cr-Commit-Position: refs/heads/master@{#36174}

Powered by Google App Engine
This is Rietveld 408576698