Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1384)

Unified Diff: services/tracing/tracing_app.cc

Issue 1970533002: Remove mojo:tracing's support for wrong-way service providers. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/tracing/tracing_app.cc
diff --git a/services/tracing/tracing_app.cc b/services/tracing/tracing_app.cc
index 930c5e5974dd3f505c9c1c458a62bce44a42feab..036e583284851222e24a364fea94512c990f9313 100644
--- a/services/tracing/tracing_app.cc
+++ b/services/tracing/tracing_app.cc
@@ -18,18 +18,6 @@ TracingApp::~TracingApp() {}
bool TracingApp::ConfigureIncomingConnection(
mojo::ApplicationConnection* connection) {
connection->AddService<TraceCollector>(this);
-
- // If someone connects to us they may want to use the TraceCollector
- // interface and/or they may want to expose themselves to be traced. Attempt
- // to connect to the TraceProvider interface to see if the application
- // connecting to us wants to be traced. They can refuse the connection or
- // close the pipe if not.
- // TODO(vtl): Remove this once we remove the "wrong way" ServiceProvider.
- TraceProviderPtr provider_ptr;
- connection->ConnectToService(&provider_ptr);
- if (provider_ptr)
- RegisterTraceProvider(provider_ptr.PassInterfaceHandle());
-
return true;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698