Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1970513002: Update platform handle (private) API "documentation"/comments. (Closed)

Created:
4 years, 7 months ago by viettrungluu
Modified:
4 years, 7 months ago
Reviewers:
azani
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Update platform handle (private) API "documentation"/comments. R=azani@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/25e32e636af1139547f8ed9bf00db5d4550de2cc

Patch Set 1 #

Total comments: 1

Patch Set 2 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -20 lines) Patch
M mojo/public/platform/native/platform_handle_private.h View 1 1 chunk +50 lines, -14 lines 0 comments Download
M mojo/public/platform/native/platform_handle_private_thunks.c View 2 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
viettrungluu
4 years, 7 months ago (2016-05-10 20:10:39 UTC) #1
azani
lgtm https://codereview.chromium.org/1970513002/diff/1/mojo/public/platform/native/platform_handle_private.h File mojo/public/platform/native/platform_handle_private.h (right): https://codereview.chromium.org/1970513002/diff/1/mojo/public/platform/native/platform_handle_private.h#newcode30 mojo/public/platform/native/platform_handle_private.h:30: // Warning: On failure, this will still take ...
4 years, 7 months ago (2016-05-10 21:15:35 UTC) #2
viettrungluu
Thanks. On 2016/05/10 21:15:35, azani wrote: > lgtm > > https://codereview.chromium.org/1970513002/diff/1/mojo/public/platform/native/platform_handle_private.h > File mojo/public/platform/native/platform_handle_private.h (right): ...
4 years, 7 months ago (2016-05-10 21:18:47 UTC) #3
viettrungluu
4 years, 7 months ago (2016-05-10 21:19:12 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
25e32e636af1139547f8ed9bf00db5d4550de2cc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698