Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Unified Diff: src/js/messages.js

Issue 1970503004: [wasm] Differentiate unnamed and empty names (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@add-utf8-check
Patch Set: Yang's last comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/isolate.cc ('k') | src/messages.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/js/messages.js
diff --git a/src/js/messages.js b/src/js/messages.js
index be33ff759b79dd0945f529636d881958f14924bc..cf8345eb037cd6489aab5f36f6bad0ba3dc16099 100644
--- a/src/js/messages.js
+++ b/src/js/messages.js
@@ -630,12 +630,6 @@ function CallSiteGetScriptNameOrSourceURL() {
function CallSiteGetFunctionName() {
// See if the function knows its own name
CheckCallSite(this, "getFunctionName");
- if (HAS_PRIVATE(this, callSiteWasmObjectSymbol)) {
- var wasm = GET_PRIVATE(this, callSiteWasmObjectSymbol);
- var func_index = GET_PRIVATE(this, callSiteWasmFunctionIndexSymbol);
- if (IS_UNDEFINED(wasm)) return "<WASM>";
- return %WasmGetFunctionName(wasm, func_index);
- }
return %CallSiteGetFunctionNameRT(this);
}
@@ -679,7 +673,8 @@ function CallSiteToString() {
var funName = this.getFunctionName();
var funcIndex = GET_PRIVATE(this, callSiteWasmFunctionIndexSymbol);
var pos = this.getPosition();
- return funName + " (<WASM>:" + funcIndex + ":" + pos + ")";
+ if (IS_NULL(funName)) funName = "<WASM UNNAMED>";
+ return funName + " (<WASM>[" + funcIndex + "]+" + pos + ")";
}
var fileName;
« no previous file with comments | « src/isolate.cc ('k') | src/messages.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698