src/wasm/wasm-module.h - Issue 1970503004: [wasm] Differentiate unnamed and empty names

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/wasm/wasm-module.h

Issue 1970503004: [wasm] Differentiate unnamed and empty names (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@add-utf8-check

Patch Set: minor doc fix Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/wasm/wasm-module.h

diff --git a/src/wasm/wasm-module.h b/src/wasm/wasm-module.h

index 0438dba7c275ab264a4af6723663b82f12f3cb3b..f67919ef88033660e6544fcf41b89a972327b14f 100644

--- a/src/wasm/wasm-module.h

+++ b/src/wasm/wasm-module.h

@@ -202,7 +202,7 @@ struct WasmModule {

// Get a string stored in the module bytes representing a name.

WasmName GetNameOrNull(uint32_t offset, uint32_t length) const {

- if (length == 0) return {NULL, 0}; // no name.

+ if (offset == 0 && length == 0) return {NULL, 0}; // no name.

CHECK(BoundsCheck(offset, offset + length));

DCHECK_GE(static_cast<int>(length), 0);

return {reinterpret_cast<const char*>(module_start + offset),