Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(914)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/isolate.cc

Issue 1970503004: [wasm] Differentiate unnamed and empty names (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@add-utf8-check
Patch Set: minor doc fix Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/js/messages.js » ('j') | src/js/messages.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/isolate.cc
diff --git a/src/isolate.cc b/src/isolate.cc
index 2d13f25b620dafb63f60fa98cca1ff2e089f2792..b6e5f480f63028a93a7af28681765925fa16866b 100644
--- a/src/isolate.cc
+++ b/src/isolate.cc
@@ -622,7 +622,7 @@ class CaptureStackTraceHelper {
Handle<Object> fun_name = handle(frame->function_name(), isolate_);
if (fun_name->IsUndefined())
fun_name = isolate_->factory()->InternalizeUtf8String(
Yang 2016/05/13 07:41:10 We should not be using InternalizeUtf8String here.
Clemens Hammacher 2016/05/17 17:43:24 Done.
- Vector<const char>("<WASM>"));
+ Vector<const char>("<WASM UNNAMED>"));
JSObject::AddProperty(stack_frame, function_key_, fun_name, NONE);
}
// Encode the function index as line number.
« no previous file with comments | « no previous file | src/js/messages.js » ('j') | src/js/messages.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698