Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Side by Side Diff: src/wasm/wasm-function-name-table.h

Issue 1970503004: [wasm] Differentiate unnamed and empty names (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@add-utf8-check
Patch Set: Yang's last comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/runtime/runtime-function.cc ('k') | src/wasm/wasm-function-name-table.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 the V8 project authors. All rights reserved. 1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_WASM_FUNCTION_NAME_TABLE_H_ 5 #ifndef V8_WASM_FUNCTION_NAME_TABLE_H_
6 #define V8_WASM_FUNCTION_NAME_TABLE_H_ 6 #define V8_WASM_FUNCTION_NAME_TABLE_H_
7 7
8 #include "src/handles.h" 8 #include "src/handles.h"
9 #include "src/objects.h" 9 #include "src/objects.h"
10 10
11 namespace v8 { 11 namespace v8 {
12 namespace internal { 12 namespace internal {
13 namespace wasm { 13 namespace wasm {
14 14
15 // Forward declarations for some WASM data structures. 15 // Forward declarations for some WASM data structures.
16 struct WasmModule; 16 struct WasmModule;
17 17
18 // Encode all function names of the WasmModule into one ByteArray. 18 // Encode all function names of the WasmModule into one ByteArray.
19 // Returns undefined if the array length would not fit in an integer value.
19 Handle<Object> BuildFunctionNamesTable(Isolate* isolate, WasmModule* module); 20 Handle<Object> BuildFunctionNamesTable(Isolate* isolate, WasmModule* module);
20 21
21 // Extract the function name for the given func_index from the wasm module. 22 // Extract the function name for the given func_index from the function name
22 // Returns undefined if the function index is invalid. 23 // table.
23 Handle<Object> GetWasmFunctionNameFromTable(Handle<ByteArray> wasm_names_table, 24 // Returns a null handle if the respective function is unnamed (not to be
24 uint32_t func_index); 25 // confused with empty names) or the function name is not a valid UTF-8 string.
26 MaybeHandle<String> GetWasmFunctionNameFromTable(
27 Handle<ByteArray> wasm_names_table, uint32_t func_index);
25 28
26 } // namespace wasm 29 } // namespace wasm
27 } // namespace internal 30 } // namespace internal
28 } // namespace v8 31 } // namespace v8
29 32
30 #endif // V8_WASM_FUNCTION_NAME_TABLE_H_ 33 #endif // V8_WASM_FUNCTION_NAME_TABLE_H_
OLDNEW
« no previous file with comments | « src/runtime/runtime-function.cc ('k') | src/wasm/wasm-function-name-table.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698