[wasm] Differentiate unnamed and empty names

src/js/messages.js

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // -------------------------------------------------------------------
 
 (function(global, utils) {
 
 %CheckIsBootstrapping();
 
@@ skipping 615 matching lines @@
   CheckCallSite(this, "getScriptNameOrSourceURL");
   return %CallSiteGetScriptNameOrSourceUrlRT(this);
 }
 
 function CallSiteGetFunctionName() {
   // See if the function knows its own name
   CheckCallSite(this, "getFunctionName");
   if (HAS_PRIVATE(this, callSiteWasmObjectSymbol)) {
     var wasm = GET_PRIVATE(this, callSiteWasmObjectSymbol);
     var func_index = GET_PRIVATE(this, callSiteWasmFunctionIndexSymbol);
-    if (IS_UNDEFINED(wasm)) return "<WASM>";
     return %WasmGetFunctionName(wasm, func_index);
   }
   return %CallSiteGetFunctionNameRT(this);
 }
 
 function CallSiteGetMethodName() {
   // See if we can find a unique property on the receiver that holds
   // this function.
   CheckCallSite(this, "getMethodName");
   return %CallSiteGetMethodNameRT(this);
@@ skipping 25 matching lines @@
 function CallSiteIsConstructor() {
   CheckCallSite(this, "isConstructor");
   return %CallSiteIsConstructorRT(this);
 }
 
 function CallSiteToString() {
   if (HAS_PRIVATE(this, callSiteWasmObjectSymbol)) {
     var funName = this.getFunctionName();
     var funcIndex = GET_PRIVATE(this, callSiteWasmFunctionIndexSymbol);
     var pos = this.getPosition();
+    if (IS_NULL_OR_UNDEFINED(funName))
+      funName = "<WASM UNNAMED>";

[titzer, 2016/05/12 09:05:51]

Should probably also add the position here.

[Clemens Hammacher, 2016/05/12 09:45:57]

It's still added in the line below, there is no return here.

[titzer, 2016/05/12 09:54:35]

Acknowledged.

     return funName + " (<WASM>:" + funcIndex + ":" + pos + ")";

[titzer, 2016/05/12 09:05:51]

bikeshed: for this line: 
" (<WASM>[" + funcIndex +"]+" + pos + ")"

[Clemens Hammacher, 2016/05/12 09:45:57]

Would you prefer this format for all wasm frames? For the simple stack traces,
we currently also output "<WASM>:funcIndex:pos".

[titzer, 2016/05/12 09:54:35]

yes

   }
 
   var fileName;
   var fileLocation = "";
   if (this.isNative()) {
     fileLocation = "native";
   } else {
     fileName = this.getScriptNameOrSourceURL();
     if (!fileName && this.isEval()) {
       fileLocation = this.getEvalOrigin();
@@ skipping 349 matching lines @@
 utils.Export(function(to) {
   to.ErrorToString = ErrorToString;
   to.MakeError = MakeError;
   to.MakeRangeError = MakeRangeError;
   to.MakeSyntaxError = MakeSyntaxError;
   to.MakeTypeError = MakeTypeError;
   to.MakeURIError = MakeURIError;
 });
 
 });