Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Unified Diff: chrome/browser/prerender/prerender_tab_helper.h

Issue 19705013: [password autofill] Remove references to PasswordForm from RenderViewImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Callback Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prerender/prerender_tab_helper.h
diff --git a/chrome/browser/prerender/prerender_tab_helper.h b/chrome/browser/prerender/prerender_tab_helper.h
index 1e889ceb854a95d6171a29407ac3c6dee62cac25..6ebd8a674a781605cc92816f745cb8499c17025f 100644
--- a/chrome/browser/prerender/prerender_tab_helper.h
+++ b/chrome/browser/prerender/prerender_tab_helper.h
@@ -8,6 +8,7 @@
#include "base/memory/scoped_ptr.h"
#include "base/memory/weak_ptr.h"
#include "base/time/time.h"
+#include "chrome/browser/password_manager/password_manager.h"
#include "content/public/browser/web_contents_observer.h"
#include "content/public/browser/web_contents_user_data.h"
#include "url/gurl.h"
@@ -37,6 +38,10 @@ class PrerenderTabHelper
EVENT_MAX_VALUE
};
+ static void CreateForWebContentsWithPasswordManager(
+ content::WebContents* web_contents,
+ PasswordManager* password_manager);
+
virtual ~PrerenderTabHelper();
// content::WebContentsObserver implementation.
@@ -59,15 +64,15 @@ class PrerenderTabHelper
const GURL& validated_url,
content::PageTransition transition_type,
content::RenderViewHost* render_view_host) OVERRIDE;
- virtual void DidNavigateAnyFrame(
- const content::LoadCommittedDetails& details,
- const content::FrameNavigateParams& params) OVERRIDE;
+
+ void PasswordSubmitted(const content::PasswordForm& form);
// Called when this prerendered WebContents has just been swapped in.
void PrerenderSwappedIn();
private:
- explicit PrerenderTabHelper(content::WebContents* web_contents);
+ PrerenderTabHelper(content::WebContents* web_contents,
+ PasswordManager* password_manager);
friend class content::WebContentsUserData<PrerenderTabHelper>;
void RecordEvent(Event event) const;
@@ -101,6 +106,9 @@ class PrerenderTabHelper
// Current URL being loaded.
GURL url_;
+ // Callback to track submitted passwords
+ PasswordManager::PasswordSubmittedCallback password_callback_;
Ilya Sherman 2013/07/27 01:09:48 Why does this need to be stored as a member variab
Garrett Casto 2013/08/03 00:38:42 Leftover from an earlier iteration. Removed.
+
base::WeakPtrFactory<PrerenderTabHelper> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(PrerenderTabHelper);

Powered by Google App Engine
This is Rietveld 408576698