[password autofill] Remove references to PasswordForm from RenderViewImpl

chrome/browser/prerender/prerender_tab_helper.cc

Index: chrome/browser/prerender/prerender_tab_helper.cc
diff --git a/chrome/browser/prerender/prerender_tab_helper.cc b/chrome/browser/prerender/prerender_tab_helper.cc
index 5203148aff46872e9d8d2909c28eb095f5101dd8..5fac07592a3cb7a5110bddbd22cc9d989a59a59b 100644
--- a/chrome/browser/prerender/prerender_tab_helper.cc
+++ b/chrome/browser/prerender/prerender_tab_helper.cc
@@ -150,9 +150,23 @@ class PrerenderTabHelper::PixelStats {
   PrerenderTabHelper* tab_helper_;
 };
 
-PrerenderTabHelper::PrerenderTabHelper(content::WebContents* web_contents)
+// static
+void PrerenderTabHelper::CreateForWebContentsWithPasswordManager(

[tburkard, 2013/07/25 16:59:17]

Can't this be done as a template in web_contents_user_data, analogous to the
formerly used implementation, so that other classes who might need this can use
it as well?

[Garrett Casto, 2013/07/25 17:34:06]

Do you mean something generic like
WebContentsUserData::CreateForWebContentsWithArgs(), or actually
WebContentsUserData::CreateForWebContentsWithPasswordManager(). I could possibly
see some use for the former, but the latter seems too specific, especially since
it would be in content referencing something in chrome. In either case, there
aren't that many classes that make use of this right now, so I doubt it's worth
the effort.

+    content::WebContents* web_contents,
+    PasswordManager* password_manager) {
+  if (!FromWebContents(web_contents)) {
+    web_contents->SetUserData(UserDataKey(),
+                              new PrerenderTabHelper(web_contents,
+                                                     password_manager));
+  }
+}
+
+PrerenderTabHelper::PrerenderTabHelper(content::WebContents* web_contents,
+                                       PasswordManager* password_manager)
     : content::WebContentsObserver(web_contents),
       weak_factory_(this) {
+  DCHECK(password_manager);
+  password_manager->AddSubmissionObserver(this);
 }
 
 PrerenderTabHelper::~PrerenderTabHelper() {
@@ -243,12 +257,10 @@ void PrerenderTabHelper::DidStartProvisionalLoadForFrame(
   }
 }
 
-void PrerenderTabHelper::DidNavigateAnyFrame(
-      const content::LoadCommittedDetails& details,
-      const content::FrameNavigateParams& params) {
+void PrerenderTabHelper::PasswordSubmitted(const content::PasswordForm& form) {
   PrerenderManager* prerender_manager = MaybeGetPrerenderManager();
-  if (params.password_form.origin.is_valid() && prerender_manager) {
-    prerender_manager->RecordLikelyLoginOnURL(params.url);
+  if (prerender_manager) {
+    prerender_manager->RecordLikelyLoginOnURL(form.origin);
     RecordEvent(EVENT_LOGIN_ACTION_ADDED);
   }
 }