[password autofill] Remove references to PasswordForm from RenderViewImpl

chrome/browser/ui/sync/one_click_signin_helper.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_SYNC_ONE_CLICK_SIGNIN_HELPER_H_
 #define CHROME_BROWSER_UI_SYNC_ONE_CLICK_SIGNIN_HELPER_H_
 
 #include <string>
 
 #include "base/gtest_prod_util.h"
+#include "chrome/browser/password_manager/password_manager.h"
 #include "chrome/browser/sync/profile_sync_service_observer.h"
 #include "chrome/browser/ui/sync/sync_promo_ui.h"
 #include "content/public/browser/navigation_controller.h"
 #include "content/public/browser/web_contents_observer.h"
 #include "content/public/browser/web_contents_user_data.h"
 #include "google_apis/gaia/google_service_auth_error.h"
 
 class Browser;
 class GURL;
 class ProfileIOData;
@@ skipping 48 matching lines @@
     DONT_OFFER,
     IGNORE_REQUEST
   };
 
   // Argument to CanOffer().
   enum CanOfferFor {
     CAN_OFFER_FOR_ALL,
     CAN_OFFER_FOR_INTERSTITAL_ONLY
   };
 
+  static void CreateForWebContentsWithPasswordManager(
+      content::WebContents* contents,
+      PasswordManager* password_manager);
+
   virtual ~OneClickSigninHelper();
 
   // Returns true if the one-click signin feature can be offered at this time.
   // If |email| is not empty, then the profile is checked to see if it's
   // already connected to a google account or if the user has already rejected
   // one-click sign-in with this email, in which cases a one click signin
   // should not be offered.
   //
   // If |can_offer_for| is |CAN_OFFER_FOR_INTERSTITAL_ONLY|, then only do the
   // checks that would affect the interstitial page.  Otherwise, do the checks
@@ skipping 66 matching lines @@
   FRIEND_TEST_ALL_PREFIXES(OneClickSigninHelperIOTest,
                            CanOfferOnIOThreadNoSigninCookies);
   FRIEND_TEST_ALL_PREFIXES(OneClickSigninHelperIOTest,
                            CanOfferOnIOThreadDisabledByPolicy);
 
   // Maximum number of navigations away from the set of valid Gaia URLs before
   // clearing the internal state of the helper.  This is necessary to support
   // SAML-based accounts, but causes bug crbug.com/181163.
   static const int kMaxNavigationsSince;
 
-  explicit OneClickSigninHelper(content::WebContents* web_contents);
+  OneClickSigninHelper(content::WebContents* web_contents,
+                       PasswordManager* password_manager);
 
   // Returns true if the one-click signin feature can be offered at this time.
   // It can be offered if the io_data is not in an incognito window and if the
   // origin of |url| is a valid Gaia sign in origin.  This function is meant
   // to called only from the IO thread.
   static Offer CanOfferOnIOThreadImpl(const GURL& url,
                                       const std::string& referrer,
                                       base::SupportsUserData* request,
                                       ProfileIOData* io_data);
 
@@ skipping 21 matching lines @@
 
   // Clear all data member of the helper, except for the error.
   void CleanTransientState();
 
   // Unitests that use a TestingProfile should call this.
   // Otherwise, clearing the pending e-mail crashes because the code expects
   // a real ResourceContext rather than the MockResourceContext a
   // TestingProfile provides.
   void SetDoNotClearPendingEmailForTesting();
 
-  // Grab Gaia password if available.
-  bool OnFormSubmitted(const content::PasswordForm& form);
+  void PasswordSubmitted(const content::PasswordForm& form);

[Ilya Sherman, 2013/07/27 01:09:48]

nit: Docs?

[Garrett Casto, 2013/08/03 00:38:42]

Done.

 
   // content::WebContentsObserver overrides.
-  virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
   virtual void NavigateToPendingEntry(
       const GURL& url,
       content::NavigationController::ReloadType reload_type) OVERRIDE;
   virtual void DidNavigateMainFrame(
       const content::LoadCommittedDetails& details,
       const content::FrameNavigateParams& params) OVERRIDE;
   virtual void DidStopLoading(
       content::RenderViewHost* render_view_host) OVERRIDE;
 
   // ProfileSyncServiceObserver.
@@ skipping 28 matching lines @@
   // Whether a Gaia URL during the sign in process was not handled by the
   // dedicated sign in process (e.g. SAML login, which redirects to a
   // non-google-controlled domain).
   // This is set to true if at least one such URL is detected.
   bool untrusted_confirmation_required_;
 
   // Allows unittests to avoid accessing the ResourceContext for clearing a
   // pending e-mail.
   bool do_not_clear_pending_email_;
 
+  // Callback for when passwords are submitted.
+  PasswordManager::PasswordSubmittedCallback password_callback_;

[Ilya Sherman, 2013/07/27 01:09:48]

Why does this need to be stored as a class member here?

[Garrett Casto, 2013/08/03 00:38:42]

Same as PrerenderTabHelper. Removed.

+
   DISALLOW_COPY_AND_ASSIGN(OneClickSigninHelper);
 };
 
 #endif  // CHROME_BROWSER_UI_SYNC_ONE_CLICK_SIGNIN_HELPER_H_