[password autofill] Remove references to PasswordForm from RenderViewImpl

chrome/browser/prerender/prerender_tab_helper.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/prerender/prerender_tab_helper.h"
 
+#include "base/bind.h"
 #include "base/metrics/histogram.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/time/time.h"
 #include "chrome/browser/predictors/logged_in_predictor_table.h"
 #include "chrome/browser/prerender/prerender_histograms.h"
 #include "chrome/browser/prerender/prerender_local_predictor.h"
 #include "chrome/browser/prerender/prerender_manager.h"
 #include "chrome/browser/prerender/prerender_manager_factory.h"
 #include "chrome/browser/profiles/profile.h"
 #include "content/public/browser/browser_thread.h"
@@ skipping 126 matching lines @@
   // Bitmap of what the last swapped in prerendered tab looked like at swapin,
   // and the WebContents that it was swapped into.
   scoped_ptr<SkBitmap> bitmap_;
   WebContents* bitmap_web_contents_;
 
   base::WeakPtrFactory<PixelStats> weak_factory_;
 
   PrerenderTabHelper* tab_helper_;
 };
 
-PrerenderTabHelper::PrerenderTabHelper(content::WebContents* web_contents)
+// static
+void PrerenderTabHelper::CreateForWebContentsWithPasswordManager(
+    content::WebContents* web_contents,
+    PasswordManager* password_manager) {
+  if (!FromWebContents(web_contents)) {
+    web_contents->SetUserData(UserDataKey(),
+                              new PrerenderTabHelper(web_contents,
+                                                     password_manager));
+  }
+}
+
+PrerenderTabHelper::PrerenderTabHelper(content::WebContents* web_contents,
+                                       PasswordManager* password_manager)
     : content::WebContentsObserver(web_contents),
+      password_callback_(base::Bind(&PrerenderTabHelper::PasswordSubmitted,
+                                    base::Unretained(this))),

[Ilya Sherman, 2013/07/27 01:09:48]

Why is base::Unretained() safe here?

[Garrett Casto, 2013/08/03 00:38:42]

Deletion of the PasswordManager and this object happen in ~WebContentsImpl() and
this deletion and the callback invocation happen on the UI thread.

[Ilya Sherman, 2013/08/06 09:34:11]

So, while you might be right, this strikes me as relying too much on
implementation details that might easily change underneath you.  I'd very much
prefer to just use a WeakPtr here and sleep that much better at night :)

       weak_factory_(this) {
+  DCHECK(password_manager);

[Ilya Sherman, 2013/07/27 01:09:48]

nit: This seems redundant with the immediate use of password_manager on the line
below.

[Garrett Casto, 2013/08/03 00:38:42]

I just wanted to give a slightly better error message, though I suppose it
should be pretty obvious in either case. Removed.

+  password_manager->AddSubmissionCallback(password_callback_);
 }
 
 PrerenderTabHelper::~PrerenderTabHelper() {
 }
 
 void PrerenderTabHelper::ProvisionalChangeToMainFrameUrl(
     const GURL& url,
     content::RenderViewHost* render_view_host) {
   url_ = url;
   RecordEvent(EVENT_MAINFRAME_CHANGE);
@@ skipping 70 matching lines @@
       bool is_error_page,
       bool is_iframe_srcdoc,
       content::RenderViewHost* render_view_host) {
   if (is_main_frame) {
     // Record the beginning of a new PPLT navigation.
     pplt_load_start_ = base::TimeTicks::Now();
     actual_load_start_ = base::TimeTicks();
   }
 }
 
-void PrerenderTabHelper::DidNavigateAnyFrame(
-      const content::LoadCommittedDetails& details,
-      const content::FrameNavigateParams& params) {
+void PrerenderTabHelper::PasswordSubmitted(const content::PasswordForm& form) {
   PrerenderManager* prerender_manager = MaybeGetPrerenderManager();
-  if (params.password_form.origin.is_valid() && prerender_manager) {
-    prerender_manager->RecordLikelyLoginOnURL(params.url);
+  if (prerender_manager) {
+    prerender_manager->RecordLikelyLoginOnURL(form.origin);
     RecordEvent(EVENT_LOGIN_ACTION_ADDED);
   }
 }
 
 PrerenderManager* PrerenderTabHelper::MaybeGetPrerenderManager() const {
   return PrerenderManagerFactory::GetForProfile(
       Profile::FromBrowserContext(web_contents()->GetBrowserContext()));
 }
 
 bool PrerenderTabHelper::IsPrerendering() {
@@ skipping 57 matching lines @@
 
 void PrerenderTabHelper::RecordEventIfLoggedInURLResult(
     PrerenderTabHelper::Event event,
     scoped_ptr<bool> is_present,
     scoped_ptr<bool> lookup_succeeded) {
   if (*lookup_succeeded && *is_present)
     RecordEvent(event);
 }
 
 }  // namespace prerender