Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(801)

Unified Diff: Source/core/platform/graphics/Image.h

Issue 19705006: Use SkImage as a backing store for copying 2d Contexts to ImageBitmaps. Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Change SkImage to use srcRect pointer. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/platform/graphics/Image.h
diff --git a/Source/core/platform/graphics/Image.h b/Source/core/platform/graphics/Image.h
index ec429809053990555a0eb3727c67f5f5276764d6..aaf7f581948935f9fe08c57d2f698343eccdae2d 100644
--- a/Source/core/platform/graphics/Image.h
+++ b/Source/core/platform/graphics/Image.h
@@ -66,7 +66,7 @@ public:
virtual bool isSVGImage() const { return false; }
virtual bool isBitmapImage() const { return false; }
- virtual bool currentFrameKnownToBeOpaque() = 0;
+ virtual bool currentFrameKnownToBeOpaque() { return false; }
Justin Novosad 2013/07/22 15:35:41 No, let's keep this pure virtual. Implement it in
// Derived classes should override this if they can assure that
// the image contains only resources from its own security origin.
@@ -92,8 +92,8 @@ public:
virtual String filenameExtension() const { return String(); } // null string if unknown
- virtual void destroyDecodedData() = 0;
- virtual unsigned decodedSize() const = 0;
+ virtual void destroyDecodedData() { }
Justin Novosad 2013/07/22 15:35:41 same here
+ virtual unsigned decodedSize() const { return 0; }
Justin Novosad 2013/07/22 15:35:41 and here.
SharedBuffer* data() { return m_encodedImageData.get(); }

Powered by Google App Engine
This is Rietveld 408576698