Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: third_party/WebKit/LayoutTests/media/track/track-webvtt-tc005-header-comment.html

Issue 1970483002: Convert track-webvtt-tc[003-005] tests to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/media/track/track-webvtt-tc005-header-comment.html
diff --git a/third_party/WebKit/LayoutTests/media/track/track-webvtt-tc005-header-comment.html b/third_party/WebKit/LayoutTests/media/track/track-webvtt-tc005-header-comment.html
index 8cc7d93eb610c94f4051492f58e4a7c32fa96999..c4f4a5cff7dc85aa621d64d719a953c782f5c8a3 100644
--- a/third_party/WebKit/LayoutTests/media/track/track-webvtt-tc005-header-comment.html
+++ b/third_party/WebKit/LayoutTests/media/track/track-webvtt-tc005-header-comment.html
@@ -1,61 +1,50 @@
<!DOCTYPE html>
-<html>
- <head>
- <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
+<title>Tests that the optional comment area under the "WEBVTT" file header is properly ignored. Also, default settings and styling are currently ignored (treated as faulty cues).</title>
+<script src="track-helpers.js"></script>
+<script src="../../resources/testharness.js"></script>
+<script src="../../resources/testharnessreport.js"></script>
+<video>
+ <track src="captions-webvtt/tc005-default-styles.vtt">
+ <track src="captions-webvtt/tc005-metadata-area.vtt">
+</video>
+<script>
+async_test(function(t) {
+ var video = document.querySelector("video");
+
+ var trackElements = document.querySelectorAll("track");
+ for (var i = 0; i < video.textTracks.length; i++)
+ trackElements[i].onload = t.step_func(trackLoaded);
- <script src=../media-file.js></script>
- <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956
- (Please avoid writing new tests using video-test.js) -->
- <script src=../video-test.js></script>
- <script>
+ enableAllTextTracks(video.textTracks);
- numberOfTrackTests = 2;
+ var numberOfTracksLoaded = 0;
+ function trackLoaded() {
+ numberOfTracksLoaded++;
+ if (numberOfTracksLoaded != 2)
+ return;
- function trackLoaded()
- {
- numberOfTracksLoaded++;
- if (numberOfTracksLoaded == numberOfTrackTests) {
- testTrack(0);
- testTrack(1);
- }
- }
+ testTrack(0);
+ testTrack(1);
+ t.done();
+ }
- function testTrack(i)
+ function testTrack(index) {
+ var expected = [
{
- var expected =
- {
- length : 2,
- tests:
- [
- {
- property : "id",
- values : [1, 2],
- },
- {
- property : "startTime",
- values : [0.0, 31.0],
- },
- {
- property : "endTime",
- values : [30.5, 1200.5],
- },
- {
- property : "text",
- values : ["Bear is Coming!!!!!", "I said Bear is coming!!!!"],
- },
- ],
- };
- testCues(i, expected);
-
- allTestsEnded();
+ id : "1",
+ startTime : 0,
+ endTime : 30.5,
+ text : "Bear is Coming!!!!!"
+ },
+ {
+ id : "2",
+ startTime : 31,
+ endTime : 1200.5,
+ text : "I said Bear is coming!!!!"
}
- </script>
- </head>
- <body onload="enableAllTextTracks()">
- <p>Tests that the optional comment area under the "WEBVTT" file header is properly ignored. Also, default settings and styling are currently ignored (treated as faulty cues).</p>
- <video>
- <track src="captions-webvtt/tc005-default-styles.vtt" onload="trackLoaded()">
- <track src="captions-webvtt/tc005-metadata-area.vtt" onload="trackLoaded()">
- </video>
- </body>
-</html>
+ ];
+
+ assert_cues_equal(video.textTracks[index].cues, expected);
+ }
+});
+</script>

Powered by Google App Engine
This is Rietveld 408576698