Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2701)

Unified Diff: blimp/net/blob_channel/helium_blob_receiver_delegate.h

Issue 1970463004: Blimp: Add BlobChannel Helium messages and delegate impls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: haibinlu feedback Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/net/blob_channel/helium_blob_receiver_delegate.h
diff --git a/blimp/net/blob_channel/helium_blob_receiver_delegate.h b/blimp/net/blob_channel/helium_blob_receiver_delegate.h
new file mode 100644
index 0000000000000000000000000000000000000000..2cbcc3c5de754f6b067fa9cb4cc3f0537710a00e
--- /dev/null
+++ b/blimp/net/blob_channel/helium_blob_receiver_delegate.h
@@ -0,0 +1,34 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef BLIMP_NET_BLOB_CHANNEL_HELIUM_BLOB_RECEIVER_DELEGATE_H_
+#define BLIMP_NET_BLOB_CHANNEL_HELIUM_BLOB_RECEIVER_DELEGATE_H_
+
+#include <memory>
Wez 2016/05/20 21:46:18 Is this just needed for unique_ptr?
Kevin M 2016/05/23 20:48:08 Yes.
+
+#include "blimp/net/blimp_message_processor.h"
+#include "blimp/net/blimp_net_export.h"
+#include "blimp/net/blob_channel/blob_channel_receiver.h"
+
+namespace blimp {
+
+// Receives and processes incoming blob messages in BlimpMessage format.
Wez 2016/05/20 21:46:18 Not clear from this description what it does with
Kevin M 2016/05/23 20:48:08 Done.
+class BLIMP_NET_EXPORT HeliumBlobReceiverDelegate
+ : public BlobChannelReceiver::Delegate,
+ public BlimpMessageProcessor {
+ public:
+ HeliumBlobReceiverDelegate();
+ ~HeliumBlobReceiverDelegate() override;
+
+ private:
+ // BlimpMessageProcessor implementation.
+ void ProcessMessage(std::unique_ptr<BlimpMessage> message,
+ const net::CompletionCallback& callback) override;
Wez 2016/05/20 21:46:18 Looks like you need to include net/completion_call
Kevin M 2016/05/23 20:48:08 Done.
+
+ DISALLOW_COPY_AND_ASSIGN(HeliumBlobReceiverDelegate);
+};
+
+} // namespace blimp
+
+#endif // BLIMP_NET_BLOB_CHANNEL_HELIUM_BLOB_RECEIVER_DELEGATE_H_

Powered by Google App Engine
This is Rietveld 408576698