blimp/common/blob_cache/blob_cache.h - Issue 1970463004: Blimp: Add BlobChannel Helium messages and delegate impls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/common/blob_cache/blob_cache.h

Issue 1970463004: Blimp: Add BlobChannel Helium messages and delegate impls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: haibinlu feedback Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: blimp/common/blob_cache/blob_cache.h

diff --git a/blimp/common/blob_cache/blob_cache.h b/blimp/common/blob_cache/blob_cache.h

index 45c9eb9de438a9986e46f6b1a9152df86cae3dad..f421ec2a00c4cad5f48b4aa906a3a7ab9ad4a677 100644

--- a/blimp/common/blob_cache/blob_cache.h

+++ b/blimp/common/blob_cache/blob_cache.h

@@ -14,8 +14,8 @@

namespace blimp {

using BlobId = std::string;

-using BlobData = base::RefCountedData<const std::string>;

-using BlobDataPtr = scoped_refptr<BlobData>;

+using BlobData = base::RefCountedData<std::string>;

+using BlobDataPtr = scoped_refptr<const BlobData>;

Wez 2016/05/20 21:46:17 This seems peculiar - I think it's worth an explan

Kevin M 2016/05/23 20:48:07 Done.

// An interface for a cache of blobs.

class BLIMP_COMMON_EXPORT BlobCache {

« no previous file with comments | « no previous file | blimp/common/blob_cache/in_memory_blob_cache_unittest.cc » ('j') | blimp/common/create_blimp_message.h » ('J')