Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Unified Diff: blimp/common/logging.cc

Issue 1970463004: Blimp: Add BlobChannel Helium messages and delegate impls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « blimp/common/create_blimp_message_unittest.cc ('k') | blimp/common/logging_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/common/logging.cc
diff --git a/blimp/common/logging.cc b/blimp/common/logging.cc
index fc612ac531283af605ace0ded27a6bf7ca2facf8..174c2b4554a1111de459d0fd429f0a662d1d9f7d 100644
--- a/blimp/common/logging.cc
+++ b/blimp/common/logging.cc
@@ -12,8 +12,10 @@
#include "base/json/string_escape.h"
#include "base/lazy_instance.h"
#include "base/memory/ptr_util.h"
+#include "base/strings/string_number_conversions.h"
#include "base/strings/string_util.h"
#include "base/strings/stringprintf.h"
+#include "blimp/common/create_blimp_message.h"
#include "blimp/common/proto/blimp_message.pb.h"
namespace blimp {
@@ -248,6 +250,28 @@ class TabControlLogExtractor : public LogExtractor {
}
};
+// Logs fields from BLOB_CHANNEL messages.
+class BlobChannelLogExtractor : public LogExtractor {
+ void ExtractFields(const BlimpMessage& message,
+ LogFields* output) const override {
+ switch (message.blob_channel().type_case()) {
+ case BlobChannelMessage::TypeCase::kTransferBlob:
+ AddField("subtype", "TRANSFER_BLOB", output);
+ AddField("id",
+ base::HexEncode(
+ message.blob_channel().transfer_blob().blob_id().data(),
+ message.blob_channel().transfer_blob().blob_id().size()),
+ output);
+ AddField("payload_size",
+ message.blob_channel().transfer_blob().payload().size(),
+ output);
+ break;
+ case BlobChannelMessage::TypeCase::TYPE_NOT_SET: // unknown
+ break;
+ }
+ }
+};
+
// No fields are extracted from |message|.
class NullLogExtractor : public LogExtractor {
void ExtractFields(const BlimpMessage& message,
@@ -271,6 +295,8 @@ BlimpMessageLogger::BlimpMessageLogger() {
base::WrapUnique(new SettingsLogExtractor));
AddHandler("TAB_CONTROL", BlimpMessage::kTabControl,
base::WrapUnique(new TabControlLogExtractor));
+ AddHandler("BLOB_CHANNEL", BlimpMessage::kBlobChannel,
+ base::WrapUnique(new BlobChannelLogExtractor));
}
BlimpMessageLogger::~BlimpMessageLogger() {}
« no previous file with comments | « blimp/common/create_blimp_message_unittest.cc ('k') | blimp/common/logging_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698