Blimp: Add BlobChannel Helium messages and delegate impls.

blimp/net/blob_channel/blob_channel_receiver_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 #include <memory>
 #include <string>
 
 #include "base/memory/ptr_util.h"
 #include "base/memory/ref_counted.h"
@@ skipping 13 matching lines @@
 
 // Helper function for creating a cache payload vector from a string.
 BlobDataPtr CreatePayload(const std::string& input) {
   return BlobDataPtr(new BlobData(input));
 }
 
 MATCHER_P(BlobDataEqual, expected, "") {
   return expected->data == arg->data;
 }
 
 class NullBlobReceiverDelegate : public BlobChannelReceiver::Delegate {

[Wez, 2016/05/25 02:47:44]

nit: You could move this into test_common.h since we use it elsewhere.

However, consider replacing it with a MockBlobReceiverDelegate - that way you
can verify that it gets called to set/unset the Receiver correctly in the tests
below!

[Kevin M, 2016/05/25 20:23:38]

Moved to mock_blob_receiver.h, added mock expectations to verify setting.

  public:
-  using BlobChannelReceiver::Delegate::OnBlobReceived;
+  void SetReceiver(BlobChannelReceiver* receiver) override {}
 };
 
 class BlobChannelReceiverTest : public testing::Test {
  public:
   BlobChannelReceiverTest()
-      : delegate_(new NullBlobReceiverDelegate),
-        cache_(new testing::StrictMock<MockBlobCache>),
-        blob_receiver_(new BlobChannelReceiver(base::WrapUnique(cache_),
-                                               base::WrapUnique(delegate_)))
+      : cache_(new testing::StrictMock<MockBlobCache>),
+        blob_receiver_(BlobChannelReceiver::Create(
+            base::WrapUnique(cache_),
+            base::WrapUnique(new NullBlobReceiverDelegate)))
 
   {}
 
   ~BlobChannelReceiverTest() override {}
 
-  NullBlobReceiverDelegate* delegate_;
   testing::StrictMock<MockBlobCache>* cache_;
   std::unique_ptr<BlobChannelReceiver> blob_receiver_;
 };
 
 TEST_F(BlobChannelReceiverTest, GetKnownBlob) {
   auto payload = CreatePayload(kBlobPayload);
   EXPECT_CALL(*cache_, Get(kBlobId)).WillOnce(Return(payload));
 
   auto result = blob_receiver_->Get(kBlobId);
 
   ASSERT_NE(nullptr, result.get());
   EXPECT_EQ(result->data, payload->data);
 }
 
 TEST_F(BlobChannelReceiverTest, GetFromDelegateReceiveMethod) {
   auto payload = CreatePayload(kBlobPayload);
 
   EXPECT_CALL(*cache_, Put(kBlobId, BlobDataEqual(payload)));
   EXPECT_CALL(*cache_, Get(kBlobId)).WillOnce(Return(payload));
 
-  delegate_->OnBlobReceived(kBlobId, payload);
+  blob_receiver_->OnBlobReceived(kBlobId, payload);
 
   auto result = blob_receiver_->Get(kBlobId);
 
   ASSERT_NE(nullptr, result.get());
   EXPECT_EQ(payload->data, result->data);
 }
 
 TEST_F(BlobChannelReceiverTest, GetUnknownBlob) {
   EXPECT_CALL(*cache_, Get(kBlobId)).WillOnce(Return(nullptr));
   auto result = blob_receiver_->Get(kBlobId);
 
   ASSERT_EQ(nullptr, result.get());
 }
 
 }  // namespace
 }  // namespace blimp