Blimp: Add BlobChannel Helium messages and delegate impls.

blimp/net/blob_channel/blob_channel_integration_test.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <memory>
 
 #include "base/memory/ptr_util.h"
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
 #include "blimp/common/blob_cache/id_util.h"
@@ skipping 11 matching lines @@
 using testing::SaveArg;
 
 const char kBlobId[] = "foo1";
 const char kBlobPayload[] = "bar1";
 
 // Routes sender delegate calls to a receiver delegate object.
 // The caller is responsible for ensuring that the receiver delegate is deleted
 // after |this| is deleted.
 class SenderDelegateProxy : public BlobChannelSender::Delegate {
  public:
-  SenderDelegateProxy() {}
+  explicit SenderDelegateProxy(BlobChannelReceiver* receiver)
+      : receiver_(receiver) {}
   ~SenderDelegateProxy() override {}
 
-  // Returns a receiver object that will receive proxied calls sent to |this|.
-  std::unique_ptr<BlobChannelReceiver::Delegate> GetReceiverDelegate() {
-    DCHECK(!receiver_);
-    receiver_ = new ReceiverDelegate;
-    return base::WrapUnique(receiver_);
-  }
-
  private:
-  class ReceiverDelegate : public BlobChannelReceiver::Delegate {
-   public:
-    using BlobChannelReceiver::Delegate::OnBlobReceived;
-  };
-
   // BlobChannelSender implementation.
   void DeliverBlob(const BlobId& id, BlobDataPtr data) override {
     base::MessageLoop::current()->PostTask(
-        FROM_HERE, base::Bind(&ReceiverDelegate::OnBlobReceived,
+        FROM_HERE, base::Bind(&BlobChannelReceiver::OnBlobReceived,
                               base::Unretained(receiver_), id, data));
   }
 
-  ReceiverDelegate* receiver_ = nullptr;
+  BlobChannelReceiver* receiver_;
 
   DISALLOW_COPY_AND_ASSIGN(SenderDelegateProxy);
 };
 
 // Verifies compatibility between the sender and receiver, independent of
 // transport-level implementation details.
 class BlobChannelIntegrationTest : public testing::Test {
  public:
+  class NullBlobReceiverDelegate : public BlobChannelReceiver::Delegate {

[Wez, 2016/05/25 02:47:44]

nit: Seems more natural to declare this in a top-level anonymous namespace?

It should also have DISALLOW_COPY_AND_ASSIGN and all that jazz.

[Kevin M, 2016/05/25 20:23:38]

Done.

+   public:
+    void SetReceiver(BlobChannelReceiver* receiver) override {}
+  };
+
   BlobChannelIntegrationTest() {
-    std::unique_ptr<SenderDelegateProxy> sender_delegate(
-        new SenderDelegateProxy);
-    receiver_.reset(
-        new BlobChannelReceiver(base::WrapUnique(new InMemoryBlobCache),
-                                sender_delegate->GetReceiverDelegate()));
-    sender_.reset(new BlobChannelSender(base::WrapUnique(new InMemoryBlobCache),
-                                        std::move(sender_delegate)));
+    receiver_ = BlobChannelReceiver::Create(
+        base::WrapUnique(new InMemoryBlobCache),
+        base::WrapUnique(new NullBlobReceiverDelegate));
+    sender_.reset(new BlobChannelSender(
+        base::WrapUnique(new InMemoryBlobCache),
+        base::WrapUnique(new SenderDelegateProxy(receiver_.get()))));
   }
 
   ~BlobChannelIntegrationTest() override {}
 
  protected:
   std::unique_ptr<BlobChannelReceiver> receiver_;
   std::unique_ptr<BlobChannelSender> sender_;
   base::MessageLoop message_loop_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(BlobChannelIntegrationTest);
 };
 
 TEST_F(BlobChannelIntegrationTest, Deliver) {
   const std::string blob_id = CalculateBlobId(kBlobId);
 
   EXPECT_EQ(nullptr, receiver_->Get(blob_id).get());
   sender_->PutBlob(blob_id, CreateBlobDataPtr(kBlobPayload));
   EXPECT_EQ(nullptr, receiver_->Get(blob_id).get());
 
   EXPECT_EQ(nullptr, receiver_->Get(blob_id).get());
   sender_->DeliverBlob(blob_id);
 
   base::RunLoop().RunUntilIdle();
   EXPECT_EQ(kBlobPayload, receiver_->Get(blob_id)->data);
 }
 
 }  // namespace
 }  // namespace blimp