blimp/common/proto/blob_channel.proto - Issue 1970463004: Blimp: Add BlobChannel Helium messages and delegate impls.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: blimp/common/proto/blob_channel.proto

Issue 1970463004: Blimp: Add BlobChannel Helium messages and delegate impls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: wez feedback Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 syntax = "proto2";	5 syntax = "proto2";

6	6

7 option optimize_for = LITE_RUNTIME;	7 option optimize_for = LITE_RUNTIME;

8	8

9 package cc.proto;	9 package blimp;

10	10

11 message Vector2d {	11 message TransferBlob {

12 optional int64 x = 1;	12 optional string blob_id = 2;

13 optional int64 y = 2;	13 optional bytes payload = 1;
	nyquist 2016/05/25 20:16:01 Is there any reason why payload is id = 1 and not Is there any reason why payload is id = 1 and not first in the list? If there is, could you add a comment to that? Kevin M 2016/05/25 20:23:38 No good reason, fixed. Show quoted text On 2016/05/25 20:16:01, nyquist wrote: > Is there any reason why payload is id = 1 and not first in the list? If there > is, could you add a comment to that? No good reason, fixed.
14 }	14 }

	15

	16 message BlobChannelMessage {

	17 oneof type {

	18 // Engine => Client types.

	19 TransferBlob transfer_blob = 1;

	20 }

	21 }

OLD	NEW

« blimp/common/logging.cc ('K') | « blimp/common/proto/blimp_message.proto ('k') | blimp/net/BUILD.gn » ('j') | blimp/net/blob_channel/blob_channel_integration_test.cc » ('J')