blimp/common/proto/blob_channel.proto - Issue 1970463004: Blimp: Add BlobChannel Helium messages and delegate impls.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: blimp/common/proto/blob_channel.proto

Issue 1970463004: Blimp: Add BlobChannel Helium messages and delegate impls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: haibinlu feedback Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 syntax = "proto2";

	6

	7 option optimize_for = LITE_RUNTIME;

	8

	9 package blimp;

	10

	11 message BlobChannelMessage {

	12 enum Type {

	13 UNKNOWN = 0;

	14

	15 // Engine => Client types.

	16 TRANSFER_BLOB = 1;

	17 }

	18

	19 optional Type type = 1 [default = UNKNOWN];

	20 optional string blob_id = 2;

	21 optional bytes payload = 3;
	Wez 2016/05/20 21:46:17 nit: Want to use oneof here, and define a Transfer nit: Want to use oneof here, and define a TransferBlob message type? Kevin M 2016/05/23 20:48:07 Done. Show quoted text On 2016/05/20 21:46:17, Wez wrote: > nit: Want to use oneof here, and define a TransferBlob message type? Done.
	22 }

OLD	NEW

« blimp/common/logging.cc ('K') | « blimp/common/proto/blimp_message.proto ('k') | blimp/net/BUILD.gn » ('j') | blimp/net/blob_channel/blob_channel_receiver.h » ('J')