Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 1970443002: win toolchain: Always use ; for all env vars except PATH, even on non-Windows. (Closed)

Created:
4 years, 7 months ago by Nico
Modified:
4 years, 7 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

win toolchain: Always use ; for all env vars except PATH, even on non-Windows. lld-link expects LIB to be ;-separated even on non-Windows. Hopefully it'll eventually use a flag for system lib dirs instead of looking at env vars, but for now it looks at env vars. (clang-cl also expects INCLUDE to be ;-separated, but it already uses -imsvc instead of the INCLUDE env var to find system include dirs.) BUG=495204 Committed: https://crrev.com/b61345c8939bfc9e23f9a2442e681b54566120ca Cr-Commit-Position: refs/heads/master@{#392676}

Patch Set 1 #

Patch Set 2 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M build/toolchain/win/setup_toolchain.py View 1 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Nico
4 years, 7 months ago (2016-05-10 18:17:33 UTC) #3
scottmg
lgtm
4 years, 7 months ago (2016-05-10 18:48:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1970443002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1970443002/20001
4 years, 7 months ago (2016-05-10 18:54:30 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-10 19:15:53 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 19:18:07 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b61345c8939bfc9e23f9a2442e681b54566120ca
Cr-Commit-Position: refs/heads/master@{#392676}

Powered by Google App Engine
This is Rietveld 408576698