Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 197043005: original change (Closed)

Created:
6 years, 9 months ago by tburkard
Modified:
6 years, 9 months ago
Reviewers:
CC:
chromium-reviews, asanka, michaeln, cbentzel+watch_chromium.org, tzik, benjhayden+dwatch_chromium.org, tfarina, chromoting-reviews_chromium.org, jam, nhiroki, joi+watch-content_chromium.org, darin-cc_chromium.org, stuartmorgan+watch_chromium.org, kinuko+watch, zork+watch_chromium.org
Visibility:
Public.

Description

Allow the content browser client to specify a special cookie store to be used for a given render process id. This special cookie store will then be used for renderer messages pertaining to cookies, url fetches in net, and websockets. If the special cookie store is NULL, a default cookie store will be used. Re-submit of https://codereview.chromium.org/188693003 See https://codereview.chromium.org/188693003 for reviewers/lgtm's. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256657

Patch Set 1 #

Patch Set 2 : fix compile error #

Patch Set 3 : fix other build error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+338 lines, -206 lines) Patch
M chrome/browser/net/chrome_fraudulent_certificate_reporter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/connection_tester.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/http_pipelining_compatibility_client.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/net/spdyproxy/proxy_advisor.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugins/plugin_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_client_certificate_selector_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/ssl_client_certificate_selector_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/download_manager_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/fileapi/blob_url_request_job_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/fileapi/file_system_dir_url_request_job_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/fileapi/file_system_url_request_job_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/fileapi/file_writer_delegate_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 2 chunks +10 lines, -2 lines 0 comments Download
M content/browser/loader/resource_scheduler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_message_filter.h View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 7 chunks +36 lines, -17 lines 0 comments Download
M content/browser/renderer_host/socket_stream_dispatcher_host.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/socket_stream_host.h View 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/socket_stream_host.cc View 4 chunks +8 lines, -3 lines 0 comments Download
M content/browser/streams/stream_url_request_job_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/browser/content_browser_client.h View 2 chunks +7 lines, -0 lines 0 comments Download
M content/public/browser/content_browser_client.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M net/proxy/proxy_script_fetcher_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket_stream/socket_stream.h View 6 chunks +11 lines, -4 lines 0 comments Download
M net/socket_stream/socket_stream.cc View 5 chunks +33 lines, -23 lines 0 comments Download
M net/socket_stream/socket_stream_job.h View 5 chunks +11 lines, -5 lines 0 comments Download
M net/socket_stream/socket_stream_job.cc View 3 chunks +10 lines, -2 lines 0 comments Download
M net/socket_stream/socket_stream_job_manager.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/socket_stream/socket_stream_job_manager.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M net/socket_stream/socket_stream_unittest.cc View 18 chunks +37 lines, -44 lines 0 comments Download
M net/test/spawned_test_server/spawner_communicator.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_fetcher_core.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request.h View 5 chunks +24 lines, -0 lines 0 comments Download
M net/url_request/url_request.cc View 2 chunks +51 lines, -31 lines 0 comments Download
M net/url_request/url_request_context.h View 1 chunk +5 lines, -1 line 0 comments Download
M net/url_request/url_request_context.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M net/url_request/url_request_http_job.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M net/url_request/url_request_job.h View 2 chunks +4 lines, -0 lines 0 comments Download
M net/url_request/url_request_job.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M net/websockets/websocket_job.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M net/websockets/websocket_job_test.cc View 5 chunks +8 lines, -7 lines 0 comments Download
M net/websockets/websocket_throttle_test.cc View 9 chunks +9 lines, -18 lines 0 comments Download
M remoting/host/token_validator_factory_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/appcache/appcache_storage_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/appcache/appcache_update_job.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/appcache/appcache_url_request_job_unittest.cc View 4 chunks +8 lines, -4 lines 0 comments Download
M webkit/browser/blob/blob_url_request_job_factory.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
tburkard
6 years, 9 months ago (2014-03-12 21:39:48 UTC) #1
Message was sent while issue was closed. 
Committed patchset #3 manually as r256657.

Powered by Google App Engine
This is Rietveld 408576698