Issue 197043004: Don't fast RemoveArrayHoles in case of arguments arrays.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 197043004: Don't fast RemoveArrayHoles in case of arguments arrays. (Closed)

Created:
6 years, 9 months ago by Toon Verwaest

Modified:
6 years, 9 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Don't fast RemoveArrayHoles in case of arguments arrays. BUG=351645 LOG=n R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19848

Patch Set 2 : Addressed comments #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -11 lines)			Patch
M	src/array.js	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/objects.cc	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	src/runtime.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A +	test/mjsunit/regress/regress-sort-arguments.js	View		1 chunk	+6 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM with two nits. https://codereview.chromium.org/197043004/diff/1/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/197043004/diff/1/src/runtime.cc#newcode10517 src/runtime.cc:10517: if (object->HasFastArgumentsElements() || nit: Instead ...

6 years, 9 months ago (2014-03-12 13:31:57 UTC) #2

Toon Verwaest

6 years, 9 months ago (2014-03-12 13:42:25 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r19848 (presubmit successful).

Expand Messages | Collapse Messages

Issue 197043004: Don't fast RemoveArrayHoles in case of arguments arrays. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed comments #

Messages