chrome/browser/browsing_data/browsing_data_remover.h - Issue 1970423002: [Offline Pages] Clear offline pages when user clears cache.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browsing_data/browsing_data_remover.h

Issue 1970423002: [Offline Pages] Clear offline pages when user clears cache. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adding comments. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/browsing_data/browsing_data_remover.h

diff --git a/chrome/browser/browsing_data/browsing_data_remover.h b/chrome/browser/browsing_data/browsing_data_remover.h

index 19c8921b8d23febd1b1d7a91007405b931810970..81b7ec84d8cb9a9ae690742d95a7a5cc1385d02b 100644

--- a/chrome/browser/browsing_data/browsing_data_remover.h

+++ b/chrome/browser/browsing_data/browsing_data_remover.h

@@ -114,6 +114,8 @@ class BrowsingDataRemover : public KeyedService

REMOVE_CACHE_STORAGE = 1 << 18,

#if BUILDFLAG(ANDROID_JAVA_UI)

REMOVE_WEBAPP_DATA = 1 << 19,

+ // REMOVE_OFFLINE_PAGE_DATA is superceded by REMOVE_CACHE since

fgorski 2016/05/13 17:59:24 https://brendanscott.wordpress.com/2011/08/08/supe

+ // offline pages are considered as cache right now.

REMOVE_OFFLINE_PAGE_DATA = 1 << 20,

#endif

// The following flag is used only in tests. In normal usage, hosted app

@@ -135,7 +137,6 @@ class BrowsingDataRemover : public KeyedService

REMOVE_SITE_USAGE_DATA |

#if BUILDFLAG(ANDROID_JAVA_UI)

REMOVE_WEBAPP_DATA |

- REMOVE_OFFLINE_PAGE_DATA |

#endif

REMOVE_WEBRTC_IDENTITY,

« no previous file with comments | « no previous file | chrome/browser/browsing_data/browsing_data_remover.cc » ('j') | no next file with comments »