Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Unified Diff: chrome/browser/browsing_data/browsing_data_remover.cc

Issue 1970423002: [Offline Pages] Clear offline pages when user clears cache. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_data/browsing_data_remover.cc
diff --git a/chrome/browser/browsing_data/browsing_data_remover.cc b/chrome/browser/browsing_data/browsing_data_remover.cc
index 912a5cf71f6ea64aff0a8a29b535454d070cf26d..e142e3ff9e05d2a58e7001046d0fd23e2a12f58c 100644
--- a/chrome/browser/browsing_data/browsing_data_remover.cc
+++ b/chrome/browser/browsing_data/browsing_data_remover.cc
@@ -1004,7 +1004,9 @@ void BrowsingDataRemover::RemoveImpl(
weak_ptr_factory_.GetWeakPtr()));
}
- if ((remove_mask & REMOVE_OFFLINE_PAGE_DATA) &&
+ // For now we're considering offline pages as cache, so if we're removing
+ // cache we should remove offline pages as well.
+ if ((remove_mask & REMOVE_CACHE || remove_mask & REMOVE_OFFLINE_PAGE_DATA) &&
offline_pages::IsOfflinePagesEnabled()) {
waiting_for_clear_offline_page_data_ = true;
offline_pages::OfflinePageModelFactory::GetForBrowserContext(profile_)

Powered by Google App Engine
This is Rietveld 408576698