[mac] Let cmd-e write the selection into the find pasteboard.

Let cmd-e write the selection into the find pasteboard.

Note that chrome still does not support _reading_ from the find pasteboard, so hitting cmd-e followed by cmd-g in chrome still doesn't work. Also, cmd-f doesn't write to the find pasteboard yet either.

BUG=14562
TEST=Select some text on a web page, hit cmd-e, go to the same web page in safari, hit cmd-g. Safari should search for the text you selected in chrome.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26075

[Nico, 2009-09-07 02:39:12]

Pink: Frontend.
Darin: Backend, or suggest another reviewer for that part.

Four lines of actual code, 10 times as much for plumbing.

I remember reading some mail (by jam?) about how the browser should kill the
renderer if it sends an invalid message, but I couldn't find it, so I just do
some sanity checking in the browser.

[pink (ping after 24hrs), 2009-09-08 17:18:16]

lgtm with nits. i assume the next steps are to hook this up to our find ui and
cmd-g?

http://codereview.chromium.org/197035/diff/3001/3006
File chrome/browser/renderer_host/resource_message_filter.h (right):

http://codereview.chromium.org/197035/diff/3001/3006#newcode180
Line 180: #if defined(OS_MACOSX)
What's the harm in leaving this defined everywhere in case other platforms want
this behavior down the road?

http://codereview.chromium.org/197035/diff/3001/3007
File chrome/browser/renderer_host/resource_message_filter_mac.mm (right):

http://codereview.chromium.org/197035/diff/3001/3007#newcode11
Line 11: static const size_t kMaxFindPboardStringLength = 4096;
comment about why this constant is here and what it prevents.

[Nico, 2009-09-11 05:28:13]

Pink: Yes, next steps are to make cmd-f and cmd-g use the find pasteboard too.

Darin: If I don't hear complaints by tomorrow, 2pm PST, I will submit this with
Pink's LGTM.

http://codereview.chromium.org/197035/diff/3001/3006
File chrome/browser/renderer_host/resource_message_filter.h (right):

http://codereview.chromium.org/197035/diff/3001/3006#newcode180
Line 180: #if defined(OS_MACOSX)
On 2009/09/08 17:18:16, pink wrote:
> What's the harm in leaving this defined everywhere in case other platforms
want
> this behavior down the road?

Windows and Linux don't have find pasteboards. Seems just useless to declare it
there. But if you want, I can remove this define as well, I don't really care.

http://codereview.chromium.org/197035/diff/3001/3007
File chrome/browser/renderer_host/resource_message_filter_mac.mm (right):

http://codereview.chromium.org/197035/diff/3001/3007#newcode11
Line 11: static const size_t kMaxFindPboardStringLength = 4096;
On 2009/09/08 17:18:16, pink wrote:
> comment about why this constant is here and what it prevents.

Done.