Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1970343003: mac/gn: Add missing test file to base_unittests. (Closed)

Created:
4 years, 7 months ago by Nico
Modified:
4 years, 7 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mac/gn: Add missing test file to base_unittests. BUG=604060 Committed: https://crrev.com/63411b4d29eaf35d1dc9c4e9ea48635bd9f34bcd Cr-Commit-Position: refs/heads/master@{#393541}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M base/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Nico
4 years, 7 months ago (2016-05-13 15:27:50 UTC) #2
Robert Sesek
lgtm thanks!
4 years, 7 months ago (2016-05-13 15:49:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1970343003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1970343003/1
4 years, 7 months ago (2016-05-13 16:12:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-13 16:23:40 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 16:26:02 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/63411b4d29eaf35d1dc9c4e9ea48635bd9f34bcd
Cr-Commit-Position: refs/heads/master@{#393541}

Powered by Google App Engine
This is Rietveld 408576698