Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 1970313002: Audio notification plumbed from guest WebContents up to embedder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add test. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index 267eeb8e5360f38c727800484ca4396897bf36ff..fa0cced0425a9b8ceb6b4f5c4359c70c4a5c0a5e 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -1290,6 +1290,9 @@ void WebContentsImpl::NotifyNavigationStateChanged(
if (delegate_)
delegate_->NavigationStateChanged(this, changed_flags);
+
+ if (GetOuterWebContents())
+ GetOuterWebContents()->NotifyNavigationStateChanged(changed_flags);
}
base::TimeTicks WebContentsImpl::GetLastActiveTime() const {
@@ -3044,7 +3047,9 @@ void WebContentsImpl::InsertCSS(const std::string& css) {
}
bool WebContentsImpl::WasRecentlyAudible() {
- return audio_stream_monitor_.WasRecentlyAudible();
+ return audio_stream_monitor_.WasRecentlyAudible() ||
+ (browser_plugin_embedder_ &&
+ browser_plugin_embedder_->WereAnyGuestsRecentlyAudible());
}
void WebContentsImpl::GetManifest(const GetManifestCallback& callback) {

Powered by Google App Engine
This is Rietveld 408576698