Re-enabled URLRequestTestHTTP.BasicAuth....

Re-enabled URLRequestTestHTTP.BasicAuth.

The problem was the test was expecting |response_time| of cached responses to be the timestamp of the original request, rather than the timestamp of the last cache validation.

Also updated the header to clarify what |request_time| and |response_time| correspond to in the cached cases.

BUG=http://crbug.com/20594

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25540

[rvargas (doing something else), 2009-09-04 21:39:41]

LGTM, thanks.

http://codereview.chromium.org/197030/diff/1/3
File net/url_request/url_request_unittest.cc (right):

http://codereview.chromium.org/197030/diff/1/3#newcode1249
Line 1249: EXPECT_FALSE(req.response_time() == response_time);
nit: this test seems to use the same pattern. (and it's not the only one in this
file).

http://codereview.chromium.org/197030/diff/1/3#newcode1273
Line 1273: response_time = r.response_time();
nit: remove this line, and line 1257

[eroman, 2009-09-04 21:47:37]

http://codereview.chromium.org/197030/diff/1/3
File net/url_request/url_request_unittest.cc (right):

http://codereview.chromium.org/197030/diff/1/3#newcode1249
Line 1249: EXPECT_FALSE(req.response_time() == response_time);
On 2009/09/04 21:39:41, rvargas wrote:
> nit: this test seems to use the same pattern. (and it's not the only one in
this
> file).

Excellent point.
I have updated that test to use |was_cached()| as well.

(Note, that is the only other instance I found in this file, you say there were
others?)

http://codereview.chromium.org/197030/diff/1/3#newcode1273
Line 1273: response_time = r.response_time();
On 2009/09/04 21:39:41, rvargas wrote:
> nit: remove this line, and line 1257

Done.

[rvargas (doing something else), 2009-09-04 21:55:49]

LGTM

http://codereview.chromium.org/197030/diff/1/3
File net/url_request/url_request_unittest.cc (right):

http://codereview.chromium.org/197030/diff/1/3#newcode1249
Line 1249: EXPECT_FALSE(req.response_time() == response_time);
> (Note, that is the only other instance I found in this file, you say there
were
> others?)

no, you're right. Just two tests.