Support allowSRGBInputs on Vulkan (via secondary texture views)

Support allowSRGBInputs on Vulkan (via secondary texture views)

All textures still have a "correct" image view that matches their actual
format. For sRGB textures, we can ask for a non-sRGB view that is
created on demand (and cached), in legacy mode.

Finally, turn on sRGB support in Vulkan. The gamma GM now looks correct
in both L32 and S32.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1970293002

Committed: https://skia.googlesource.com/skia/+/f05ab1b820b482fa633544579ab4d4c6bfcdb433

[Brian Osman, 2016-05-12 17:03:02]

Description was changed from

==========
Support allowSRGBInputs on Vulkan (via secondary texture views)

All textures still have a "correct" image view that matches their actual
format. For sRGB textures, we can ask for a non-sRGB view that is
created on demand (and cached), in legacy mode.

Finally, turn on sRGB support in Vulkan. The gamma GM now looks correct
in both L32 and S32.

BUG=skia:
==========

to

==========
Support allowSRGBInputs on Vulkan (via secondary texture views)

All textures still have a "correct" image view that matches their actual
format. For sRGB textures, we can ask for a non-sRGB view that is
created on demand (and cached), in legacy mode.

Finally, turn on sRGB support in Vulkan. The gamma GM now looks correct
in both L32 and S32.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Brian Osman, 2016-05-12 17:04:01]

The CQ bit was checked by brianosman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-12 17:04:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1970293002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1970293002/1

[Brian Osman, 2016-05-12 17:05:25]

brianosman@google.com changed reviewers:
+ bsalomon@google.com, egdaniel@google.com, jvanverth@google.com

[commit-bot: I haz the power, 2016-05-12 17:21:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-12 17:21:45]

Dry run: This issue passed the CQ dry run.

[jvanverth1, 2016-05-12 17:27:36]

lgtm + comment

https://codereview.chromium.org/1970293002/diff/1/src/gpu/vk/GrVkUtil.cpp
File src/gpu/vk/GrVkUtil.cpp (right):

https://codereview.chromium.org/1970293002/diff/1/src/gpu/vk/GrVkUtil.cpp#new...
src/gpu/vk/GrVkUtil.cpp:210: break;
Probably want a default case here -- I think some compilers may complain.

[Brian Osman, 2016-05-12 17:39:17]

The CQ bit was checked by brianosman@google.com

[Brian Osman, 2016-05-12 17:39:18]

The patchset sent to the CQ was uploaded after l-g-t-m from jvanverth@google.com
Link to the patchset: https://codereview.chromium.org/1970293002/#ps20001
(title: "default case for switch")

[commit-bot: I haz the power, 2016-05-12 17:39:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1970293002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1970293002/20001

[egdaniel, 2016-05-12 17:50:51]

On 2016/05/12 17:39:25, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1970293002/20001
> View timeline at
>  https://chromium-cq-status.appspot.com/patch-timeline/1970293002/20001

My only request which could be done in a follow up CL, is to not go from
VkFormat to VkSRGBFormat in the util function. The util function handles all the
VkFormats when in reality we only use two for sRGB. I would go from
GrPixelConfig to GrSRGBPixelConfig and then that to VkFormat.

[Brian Osman, 2016-05-12 17:54:11]

On 2016/05/12 17:50:51, egdaniel wrote:
> On 2016/05/12 17:39:25, commit-bot: I haz the power wrote:
> > CQ is trying da patch. Follow status at
> >  https://chromium-cq-status.appspot.com/patch-status/1970293002/20001
> > View timeline at
> >  https://chromium-cq-status.appspot.com/patch-timeline/1970293002/20001
> 
> My only request which could be done in a follow up CL, is to not go from
> VkFormat to VkSRGBFormat in the util function. The util function handles all
the
> VkFormats when in reality we only use two for sRGB. I would go from
> GrPixelConfig to GrSRGBPixelConfig and then that to VkFormat.

I thought about that more, and my only hesitation is that I know Brian wants
to get rid of GrPixelConfig. In my mind, that means a world where each backend
generally works in the native types of that backend. As it's implemented now,
it will JustWork(TM) if we add more sRGB pixel configs (or get rid of pixel
config entirely).

[commit-bot: I haz the power, 2016-05-12 18:01:12]

Description was changed from

==========
Support allowSRGBInputs on Vulkan (via secondary texture views)

All textures still have a "correct" image view that matches their actual
format. For sRGB textures, we can ask for a non-sRGB view that is
created on demand (and cached), in legacy mode.

Finally, turn on sRGB support in Vulkan. The gamma GM now looks correct
in both L32 and S32.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Support allowSRGBInputs on Vulkan (via secondary texture views)

All textures still have a "correct" image view that matches their actual
format. For sRGB textures, we can ask for a non-sRGB view that is
created on demand (and cached), in legacy mode.

Finally, turn on sRGB support in Vulkan. The gamma GM now looks correct
in both L32 and S32.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/f05ab1b820b482fa633544579ab4d4c6bfcdb433
==========

[commit-bot: I haz the power, 2016-05-12 18:01:13]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/f05ab1b820b482fa633544579ab4d4c6bfcdb433